From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#7716: 23.2.91; Pretest Windows binary doesn't support PNG images Date: Fri, 31 Dec 2010 14:46:40 +0200 Message-ID: <83fwteaz4f.fsf@gnu.org> References: <87k4j0cp2z.fsf@gmail.com> <83vd2ke2p7.fsf@gnu.org> <877hf0ck7a.fsf@gmail.com> <83r5d7ec4p.fsf@gnu.org> <8339pmernh.fsf@gnu.org> <83zkruciq4.fsf@gnu.org> <87r5d6azlb.fsf@gmail.com> <83ipyic8mw.fsf@gnu.org> <4D1BCAE8.4080803@gnu.org> <83k4irc309.fsf@gnu.org> <87y677gsll.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1293800029 20376 80.91.229.12 (31 Dec 2010 12:53:49 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 31 Dec 2010 12:53:49 +0000 (UTC) Cc: 7716-done@debbugs.gnu.org To: Jason Rumney Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 31 13:53:44 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PYeUJ-0008Mz-On for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Dec 2010 13:53:43 +0100 Original-Received: from localhost ([127.0.0.1]:36271 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PYeUJ-00037e-7o for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Dec 2010 07:53:43 -0500 Original-Received: from [140.186.70.92] (port=42274 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PYeUA-000338-Qd for bug-gnu-emacs@gnu.org; Fri, 31 Dec 2010 07:53:37 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PYeU9-0000y4-GH for bug-gnu-emacs@gnu.org; Fri, 31 Dec 2010 07:53:34 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53618) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PYeU9-0000xv-Ed for bug-gnu-emacs@gnu.org; Fri, 31 Dec 2010 07:53:33 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PYeF8-0006Vz-Me for bug-gnu-emacs@gnu.org; Fri, 31 Dec 2010 07:38:02 -0500 Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Dec 2010 12:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 7716 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: Mail-Followup-To: 7716@debbugs.gnu.org, eliz@gnu.org Original-Received: via spool by 7716-done@debbugs.gnu.org id=D7716.129379907125024 (code D ref 7716); Fri, 31 Dec 2010 12:38:02 +0000 Original-Received: (at 7716-done) by debbugs.gnu.org; 31 Dec 2010 12:37:51 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PYeEv-0006VZ-LJ for submit@debbugs.gnu.org; Fri, 31 Dec 2010 07:37:50 -0500 Original-Received: from mtaout21.012.net.il ([80.179.55.169]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PYeEs-0006VL-CE for 7716-done@debbugs.gnu.org; Fri, 31 Dec 2010 07:37:47 -0500 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LEA00200LXZ5W00@a-mtaout21.012.net.il> for 7716-done@debbugs.gnu.org; Fri, 31 Dec 2010 14:44:34 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.124.219.104]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LEA0014AM27QA90@a-mtaout21.012.net.il>; Fri, 31 Dec 2010 14:44:32 +0200 (IST) In-reply-to: <87y677gsll.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 31 Dec 2010 07:38:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:42948 Archived-At: > From: Jason Rumney > Cc: bug-gnu-emacs@gnu.org > Date: Thu, 30 Dec 2010 23:58:46 +0800 > > Eli Zaretskii writes: > > Faced with a choice between 1.4 and an old 1.2 with known security > vulnerabilities, I know which one I'd rather recommend to users. I agree, but I don't want to force users who build their own Emacs to upgrade to a newer libpng just to have PNG support in Emacs. So I installed (on the emacs-23 branch) a set of changes that expose to Lisp the version of libpng against which Emacs was compiled, and then w32-win.el sets up the PNG part of image-library-alist (dynamic-library-alist in Emacs 24) as appropriate for what was used during compilation. While at that, I also fixed image.c to avoid a compiler warning due to direct access to png_ptr->jmpbuf.