From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23540: 25.1.50; make-ipv4-tcp-server-with-unspecified-port fails Date: Sun, 15 May 2016 19:15:22 +0300 Message-ID: <83futj5mcl.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1463329302 24304 80.91.229.3 (15 May 2016 16:21:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 15 May 2016 16:21:42 +0000 (UTC) Cc: 23540@debbugs.gnu.org, larsi@gnus.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 15 18:21:26 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b1yn5-00042Q-Cj for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 May 2016 18:21:15 +0200 Original-Received: from localhost ([::1]:40879 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1yn4-0008RS-8a for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 May 2016 12:21:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43910) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1ymx-0008Mc-Jl for bug-gnu-emacs@gnu.org; Sun, 15 May 2016 12:21:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b1yms-0007d4-H4 for bug-gnu-emacs@gnu.org; Sun, 15 May 2016 12:21:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40589) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1yms-0007d0-EB for bug-gnu-emacs@gnu.org; Sun, 15 May 2016 12:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b1yms-0002MY-AQ for bug-gnu-emacs@gnu.org; Sun, 15 May 2016 12:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 May 2016 16:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23540 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23540-submit@debbugs.gnu.org id=B23540.14633292569056 (code B ref 23540); Sun, 15 May 2016 16:21:02 +0000 Original-Received: (at 23540) by debbugs.gnu.org; 15 May 2016 16:20:56 +0000 Original-Received: from localhost ([127.0.0.1]:52926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b1ymm-0002M0-IP for submit@debbugs.gnu.org; Sun, 15 May 2016 12:20:56 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52897) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b1yml-0002Lk-3L for 23540@debbugs.gnu.org; Sun, 15 May 2016 12:20:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b1ymb-0007bB-Q3 for 23540@debbugs.gnu.org; Sun, 15 May 2016 12:20:49 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42921) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1yhV-00074A-ON; Sun, 15 May 2016 12:15:29 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1176 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b1yhT-0003uk-Ce; Sun, 15 May 2016 12:15:28 -0400 In-reply-to: (message from Ken Brown on Sun, 15 May 2016 08:16:34 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118263 Archived-At: > From: Ken Brown > Date: Sun, 15 May 2016 08:16:34 -0400 > Cc: Lars Ingebrigtsen > > On 5/14/2016 9:36 PM, Ken Brown wrote: > > Commit b73e525, as corrected by commit 4639bc9, causes the test > > make-ipv4-tcp-server-with-unspecified-port in > > test/lisp/net/network-streams-tests.el to fail with the error > > > > Invalid argument 4 of operation `open-network-stream'. > > > > What happens is that make-network-process calls > > set_network_socket_coding_system, which calls open-network-stream with > > service eq t, which leads to the error in a way that I haven't sorted out. > > I didn't get that last step right. The error is generated by > Ffind_operation_coding_system when it is called by > > CALLN (Ffind_operation_coding_system, > Qopen_network_stream, name, p->buffer, > host, service) > > in set_network_socket_coding_system. Ffind_operation_coding_system includes an explicit test for the 4th argument to be an integer: if (!(STRINGP (target) || (EQ (operation, Qinsert_file_contents) && CONSP (target) && STRINGP (XCAR (target)) && BUFFERP (XCDR (target))) || (EQ (operation, Qopen_network_stream) && INTEGERP (target)))) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ error ("Invalid argument %"pI"d of operation `%s'", XFASTINT (target_idx) + 1, SDATA (SYMBOL_NAME (operation))); This should obviously be augmented, now that the value can also be t.