From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template =?UTF-8?Q?=E2=80=98g=E2=80=99:?= Match data clobbered by buffer modification hooks) Date: Fri, 22 Jul 2016 09:43:05 +0300 Message-ID: <83fur2xjeu.fsf@gnu.org> References: <87vb066ejv.fsf@linaro.org> <87a8hgkwcb.fsf@linaro.org> <8360s42mcb.fsf@gnu.org> <87eg6rgmlg.fsf@gmail.com> <83lh0y24y6.fsf@gnu.org> <83eg6q1hbo.fsf@gnu.org> <83a8hd1vzi.fsf@gnu.org> <834m7l1u8u.fsf@gnu.org> <83shv4z7e8.fsf@gnu.org> <83inw0yw9q.fsf@gnu.org> <87bn1rdd1f.fsf@users.sourceforge.net> <83h9bjzp5i.fsf@gnu.org> <877fcfd79w.fsf@users.sourceforge.net> <83a8hbysmw.fsf@gnu.org> <874m7icwdg.fsf@users.sourceforge.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1469169863 24521 80.91.229.3 (22 Jul 2016 06:44:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 22 Jul 2016 06:44:23 +0000 (UTC) Cc: nljlistbox2@gmail.com, jwiegley@gmail.com, rpluim@gmail.com, 23917@debbugs.gnu.org, monnier@iro.umontreal.ca, alex.bennee@linaro.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 22 08:44:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bQUBw-0005yr-MS for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Jul 2016 08:44:12 +0200 Original-Received: from localhost ([::1]:45393 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQUBv-0008Ag-A9 for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Jul 2016 02:44:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQUBp-0008Ab-FB for bug-gnu-emacs@gnu.org; Fri, 22 Jul 2016 02:44:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQUBm-0007mQ-9o for bug-gnu-emacs@gnu.org; Fri, 22 Jul 2016 02:44:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48402) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQUBm-0007mE-5X; Fri, 22 Jul 2016 02:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bQUBl-0007MD-UC; Fri, 22 Jul 2016 02:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Date: Fri, 22 Jul 2016 06:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23917 X-GNU-PR-Package: emacs,org-mode X-GNU-PR-Keywords: Original-Received: via spool by 23917-submit@debbugs.gnu.org id=B23917.146916980228230 (code B ref 23917); Fri, 22 Jul 2016 06:44:01 +0000 Original-Received: (at 23917) by debbugs.gnu.org; 22 Jul 2016 06:43:22 +0000 Original-Received: from localhost ([127.0.0.1]:60739 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQUB7-0007LF-PE for submit@debbugs.gnu.org; Fri, 22 Jul 2016 02:43:21 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQUB6-0007L2-3n for 23917@debbugs.gnu.org; Fri, 22 Jul 2016 02:43:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQUAz-0007eV-Nh for 23917@debbugs.gnu.org; Fri, 22 Jul 2016 02:43:14 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34488) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQUAm-0007cM-GU; Fri, 22 Jul 2016 02:43:00 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1380 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bQUAk-00070o-9M; Fri, 22 Jul 2016 02:42:58 -0400 In-reply-to: <874m7icwdg.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121402 Archived-At: > From: npostavs@users.sourceforge.net > Cc: 23917@debbugs.gnu.org, nljlistbox2@gmail.com, jwiegley@gmail.com, rpluim@gmail.com, monnier@iro.umontreal.ca, alex.bennee@linaro.org > Date: Thu, 21 Jul 2016 21:08:43 -0400 > > I made the same adjustments to the saved sub_start and sub_end > variables, but I had a mistake in that adjustment which caused the false > positives. Fixed in the attached v2 patch. We could just drop the > check, though I've already found it useful to catch bugs > (https://github.com/joaotavora/yasnippet/issues/720). > > If I drop the checks (see attached v3 patch), then after following the > bug#23869 recipe, I get: > > ## -*- Octave -*- > -module(bug). > -export([identity/1, is_even/1, size/1, reverse/1]). OK, let's wait for a few days to give time to the people who were affected by the issue to test the patch, and if no new issues come up, please push the version with the error code to emacs-25. Thanks.