unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: lists@dima.secretsauce.net, 24071@debbugs.gnu.org
Subject: bug#24071: [PATCH] Refactor regex character class parsing in [:name:]
Date: Wed, 27 Jul 2016 19:28:25 +0300	[thread overview]
Message-ID: <83fuqvrqom.fsf@gnu.org> (raw)
In-Reply-To: <xa1t37mv3xrz.fsf@mina86.com> (message from Michal Nazarewicz on Wed, 27 Jul 2016 17:29:04 +0200)

> From: Michal Nazarewicz <mina86@mina86.com>
> Cc: 24071@debbugs.gnu.org
> Date: Wed, 27 Jul 2016 17:29:04 +0200
> 
> > If we are going to make some serious refactoring in regex.c, I think
> > we should start with having a test suite for it.
> 
> I agree.  Which is why I started test/src/regex-tests.el¹.  Since this
> patch touches only character classes I limited the tests to character
> classes.

I know.  What I wrote was not a complaint about the past, it was a
suggestion for the future.  A single localized change doesn't yet
justify importing a large test suite.  But this later patch looks like
a beginning of a series of refactoring (is it?), hopefully followed by
more features, so I thought we should have a firm ground first.

> > The dima_regex_embedded_modifiers branch, created by Dima Kogan
> > (CC'ed) in the Emacs repository includes a suite taken from glibc.
> > Dima, could you perhaps merge the parts of the test suite that can
> > already be used to the master branch, so that we could use them to
> > verify changes in regex.c?
> 
> This looks relatively straightforward;  I can take care of it.  I’ll
> send a link to the result soon.

Thanks.





  reply	other threads:[~2016-07-27 16:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-25 22:54 bug#24071: [PATCH] Refactor regex character class parsing in [:name:] Michal Nazarewicz
2016-07-26 14:46 ` Eli Zaretskii
2016-07-27 15:29   ` Michal Nazarewicz
2016-07-27 16:28     ` Eli Zaretskii [this message]
2016-07-27 18:30       ` Michal Nazarewicz
2016-07-27 16:50   ` bug#24071: [PATCH 1/7] New regex tests imported from glibc 2.21 Michal Nazarewicz
2016-07-27 16:50     ` bug#24071: [PATCH 2/7] Added driver for the regex tests Michal Nazarewicz
2016-07-27 16:50     ` bug#24071: [PATCH 3/7] Fix reading of regex-resources in regex-tests Michal Nazarewicz
2016-07-27 16:50     ` bug#24071: [PATCH 4/7] Don’t (require 'cl) Michal Nazarewicz
2016-07-27 16:50     ` bug#24071: [PATCH 5/7] Split regex glibc test cases into separet tests Michal Nazarewicz
2016-07-27 16:50     ` bug#24071: [PATCH 6/7] Remove dead opcodes in regex bytecode Michal Nazarewicz
2016-07-27 16:50     ` bug#24071: [PATCH 7/7] Refactor regex character class parsing in [:name:] Michal Nazarewicz
2016-07-29  5:31   ` bug#24071: [PATCH] " Dima Kogan
2016-07-29  5:53     ` Eli Zaretskii
2016-07-29 13:07     ` Michal Nazarewicz
2016-08-02 16:06 ` Michal Nazarewicz
2016-08-02 16:46   ` Eli Zaretskii
2016-08-02 17:54     ` Michal Nazarewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fuqvrqom.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=24071@debbugs.gnu.org \
    --cc=lists@dima.secretsauce.net \
    --cc=mina86@mina86.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).