From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24104: 25.1.50; frame-or-buffer-changed-p also check file size Date: Fri, 29 Jul 2016 16:20:35 +0300 Message-ID: <83fuqsr36k.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1469798548 5758 80.91.229.3 (29 Jul 2016 13:22:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Jul 2016 13:22:28 +0000 (UTC) Cc: 24104@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 29 15:22:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bT7k0-0007mn-Rh for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Jul 2016 15:22:16 +0200 Original-Received: from localhost ([::1]:59580 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT7ju-0001vW-Od for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Jul 2016 09:22:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT7jp-0001vR-M9 for bug-gnu-emacs@gnu.org; Fri, 29 Jul 2016 09:22:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bT7jm-0000pw-8l for bug-gnu-emacs@gnu.org; Fri, 29 Jul 2016 09:22:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52847) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT7jm-0000ps-5I for bug-gnu-emacs@gnu.org; Fri, 29 Jul 2016 09:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bT7jm-0002Lu-1s for bug-gnu-emacs@gnu.org; Fri, 29 Jul 2016 09:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Jul 2016 13:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24104 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24104-submit@debbugs.gnu.org id=B24104.14697984698978 (code B ref 24104); Fri, 29 Jul 2016 13:22:02 +0000 Original-Received: (at 24104) by debbugs.gnu.org; 29 Jul 2016 13:21:09 +0000 Original-Received: from localhost ([127.0.0.1]:50144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bT7iu-0002Kj-Ts for submit@debbugs.gnu.org; Fri, 29 Jul 2016 09:21:09 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35047) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bT7it-0002KV-B2 for 24104@debbugs.gnu.org; Fri, 29 Jul 2016 09:21:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bT7ik-0000gr-P8 for 24104@debbugs.gnu.org; Fri, 29 Jul 2016 09:21:02 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59957) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT7ik-0000gX-M4; Fri, 29 Jul 2016 09:20:58 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1551 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bT7if-0001fg-LL; Fri, 29 Jul 2016 09:20:57 -0400 In-reply-to: (message from Tino Calancha on Fri, 29 Jul 2016 21:10:29 +0900 (JST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121680 Archived-At: > From: Tino Calancha > Date: Fri, 29 Jul 2016 21:10:29 +0900 (JST) > > > Assume a buffer BUF, with size, SIZE, returning non-nil for predicate > 'buffer-modified-p'; then we write some text on BUF, so that the > new size is SIZE_2 != SIZE. > In this scenario, 'frame-or-buffer-changed-p' return nil, i.e., > the buffer state appears to not have changed. Because it didn't. The buffer was changed, and it still is. In particular, the original change that caused buffer-modified-p to return non-nil could also be (and normally is) a change in the size of the buffer. > It might be convenient to extend 'frame-or-buffer-changed-p' so that, > it also check the buffer size. This function is used to decide whether we need to recompute menus, so your proposed change will cause extra recomputation of them. I'm not sure we want that, as recomputing menus might be expensive. > Then, for instance, Ibuffer operating > on auto mode ('ibuffer-auto-mode') would update the listing. If Ibuffer has some problem, I suggest to describe that problem and try solving it for Ibuffer alone. Thanks.