unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#28817: incorrect NEWS entry about vc-state faces
@ 2017-10-13 18:28 Charles A. Roelli
  2017-10-13 18:41 ` Eli Zaretskii
  0 siblings, 1 reply; 4+ messages in thread
From: Charles A. Roelli @ 2017-10-13 18:28 UTC (permalink / raw)
  To: 28817

In the 26.0.90 NEWS file we have:

*** The VC state indicator in the mode line now defaults to more
colorful faces to make it more obvious to the user what the state is.
See the 'vc-faces' customization group.

which was added in these commits:

* | | | | | | | | | | | | | | | | | 65fa442..: Lars Ingebrigtsen 2016-03-01 Add a NEWS entry for the colorful VC indicator
  commit 65fa442f2bae42d3f9b06264ca432073ee3197c3
  Author: Lars Ingebrigtsen <larsi@gnus.org>
  Date:   Tue Mar 1 14:31:35 2016 +1100

  Add a NEWS entry for the colorful VC indicator

* | | | | | | | | | | | | | | | | | 2621c29..: Lars Ingebrigtsen 2016-03-01 Use colors in the VC mode lines
  commit 2621c293d82c15c00d9e73a8db75d70da7d0a23b
  Author: Lars Ingebrigtsen <larsi@gnus.org>
  Date:   Tue Mar 1 14:25:27 2016 +1100

  Use colors in the VC mode lines

  * lisp/vc/vc-hooks.el: Make the mode line faces default to
  using colors to more clearly tell the user what the status is.

The NEWS entry commit seems to have made it to Emacs 26, but the mode
line faces are still the same as in Emacs 25.  Looks like commit
2621c29 got lost somehow.

Also, not sure why this group is defined (in vc-hooks.el):

(defgroup vc-state-faces nil
  "Faces used in the mode line by the VC state indicator."
  :group 'vc-faces
  :group 'mode-line
  :version "25.1")

then never used.  It looks like the vc-state-*/vc-*-state faces are
meant to inherit from it, but it's not clear.  It also makes the
customization buffers confusing.





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-11-21 19:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-13 18:28 bug#28817: incorrect NEWS entry about vc-state faces Charles A. Roelli
2017-10-13 18:41 ` Eli Zaretskii
2017-10-16 14:34   ` Charles A. Roelli
2017-11-21 19:40     ` Charles A. Roelli

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).