From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow Date: Mon, 05 Feb 2018 05:33:38 +0200 Message-ID: <83fu6g860d.fsf@gnu.org> References: <87d28rt4jl.fsf@telefonica.net> <874lmxloo1.fsf@mail.linkov.net> <87d11kquw2.fsf@mail.linkov.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1517801548 22520 195.159.176.226 (5 Feb 2018 03:32:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 5 Feb 2018 03:32:28 +0000 (UTC) Cc: 19045@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 05 04:32:24 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiXVo-0004cl-L9 for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Feb 2018 04:32:08 +0100 Original-Received: from localhost ([::1]:46727 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eiXXp-0002BZ-QB for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Feb 2018 22:34:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eiXXf-0002A0-39 for bug-gnu-emacs@gnu.org; Sun, 04 Feb 2018 22:34:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eiXXe-0005fu-3K for bug-gnu-emacs@gnu.org; Sun, 04 Feb 2018 22:34:03 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49678) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eiXXd-0005ff-Um for bug-gnu-emacs@gnu.org; Sun, 04 Feb 2018 22:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eiXXd-00048o-PQ for bug-gnu-emacs@gnu.org; Sun, 04 Feb 2018 22:34:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Feb 2018 03:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19045 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19045-submit@debbugs.gnu.org id=B19045.151780163915911 (code B ref 19045); Mon, 05 Feb 2018 03:34:01 +0000 Original-Received: (at 19045) by debbugs.gnu.org; 5 Feb 2018 03:33:59 +0000 Original-Received: from localhost ([127.0.0.1]:57575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiXXb-00048Y-AN for submit@debbugs.gnu.org; Sun, 04 Feb 2018 22:33:59 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:42916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiXXX-00048I-Sl for 19045@debbugs.gnu.org; Sun, 04 Feb 2018 22:33:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eiXXP-0005EY-EZ for 19045@debbugs.gnu.org; Sun, 04 Feb 2018 22:33:50 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39789) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eiXXP-0005EP-Ak; Sun, 04 Feb 2018 22:33:47 -0500 Original-Received: from [176.228.60.248] (port=3574 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eiXXO-0008BU-NL; Sun, 04 Feb 2018 22:33:47 -0500 In-reply-to: <87d11kquw2.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 04 Feb 2018 23:58:53 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142924 Archived-At: > From: Juri Linkov > Date: Sun, 04 Feb 2018 23:58:53 +0200 > > > Too bad that a new useful customizable variable > > vc-git-print-log-follow is not mentioned in NEWS.26. > > > > It works quite well, but only with the following fix > > that puts more restrictions - it checks not only > > for a directory, but also if it is a single file. > > > > The whole patch is intended for the emacs-26 branch: > > Pushed to the emacs-26 branch. Please don't push anything to the release branch without John's or mine explicit approval. As things are, I'm very busy these days, and didn't yet have time to review the patch thoroughly, so I'm not sure I'm happy with its being pushed. > diff --git a/lisp/vc/vc-dispatcher.el b/lisp/vc/vc-dispatcher.el > index b0d2221..efdd29e 100644 > --- a/lisp/vc/vc-dispatcher.el > +++ b/lisp/vc/vc-dispatcher.el > @@ -313,6 +313,8 @@ vc-do-command > (status 0)) > (when files > (setq squeezed (nconc squeezed files))) > + (let ((inhibit-message t)) > + (message "Running %s %s" command (vc-delistify squeezed))) > (let (;; Since some functions need to parse the output > ;; from external commands, set LC_MESSAGES to C. > (process-environment (cons "LC_MESSAGES=C" process-environment)) I don't understand why would we want to hard-code the fact that these commands are not shown in the echo area.