From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow Date: Sat, 10 Feb 2018 13:07:09 +0200 Message-ID: <83fu692jdu.fsf@gnu.org> References: <87d28rt4jl.fsf@telefonica.net> <874lmxloo1.fsf@mail.linkov.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1518260789 3240 195.159.176.226 (10 Feb 2018 11:06:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 10 Feb 2018 11:06:29 +0000 (UTC) Cc: 19045@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 10 12:06:25 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekSyv-000865-KD for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Feb 2018 12:06:09 +0100 Original-Received: from localhost ([::1]:54793 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ekT0x-0007Iy-0C for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Feb 2018 06:08:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ekT0n-0007IF-EO for bug-gnu-emacs@gnu.org; Sat, 10 Feb 2018 06:08:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ekT0k-0007xu-2K for bug-gnu-emacs@gnu.org; Sat, 10 Feb 2018 06:08:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56455) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ekT0j-0007xm-VJ for bug-gnu-emacs@gnu.org; Sat, 10 Feb 2018 06:08:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ekT0j-0003gi-Oa for bug-gnu-emacs@gnu.org; Sat, 10 Feb 2018 06:08:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Feb 2018 11:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19045 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19045-submit@debbugs.gnu.org id=B19045.151826085914148 (code B ref 19045); Sat, 10 Feb 2018 11:08:01 +0000 Original-Received: (at 19045) by debbugs.gnu.org; 10 Feb 2018 11:07:39 +0000 Original-Received: from localhost ([127.0.0.1]:36119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekT0N-0003g8-2I for submit@debbugs.gnu.org; Sat, 10 Feb 2018 06:07:39 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:48836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekT0K-0003fu-RR for 19045@debbugs.gnu.org; Sat, 10 Feb 2018 06:07:37 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ekT0A-0007T5-Re for 19045@debbugs.gnu.org; Sat, 10 Feb 2018 06:07:31 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36793) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ekT0A-0007Sv-Ox; Sat, 10 Feb 2018 06:07:26 -0500 Original-Received: from [176.228.60.248] (port=3486 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ekT0A-0006GE-5M; Sat, 10 Feb 2018 06:07:26 -0500 In-reply-to: <874lmxloo1.fsf@mail.linkov.net> (message from Juri Linkov on Sat, 03 Feb 2018 23:59:58 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143085 Archived-At: > From: Juri Linkov > Date: Sat, 03 Feb 2018 23:59:58 +0200 > > (defcustom vc-git-print-log-follow nil > - "If true, follow renames in Git logs for files." > + "If true, follow renames in Git logs for a single file." > :type 'boolean > :version "26.1") > > @@ -1019,8 +1019,9 @@ If LIMIT is non-nil, show no more than this many entries." > (append > '("log" "--no-color") > (when (and vc-git-print-log-follow > - (not (cl-some #'file-directory-p files))) > - ;; "--follow" on directories is broken > + (null (cdr files)) > + (not (file-directory-p (car files)))) > + ;; "--follow" on directories or multiple files is broken > ;; https://debbugs.gnu.org/cgi/bugreport.cgi?bug=8756 > ;; https://debbugs.gnu.org/cgi/bugreport.cgi?bug=16422 > (list "--follow")) What does this mean "is broken" in this context? Is this a Git bug/misfeature, or is that vc-git.el problem? I cannot figure out the answer by reading the cited bug reports. And the doc string doesn't sound detailed enough to me, as it doesn't tell enough about the commands that are affected. Since this is now on the release branch, we should fix these issues ASAP. Thanks.