bug#32423: 27.0.50; Compilation fails when sh points to zsh

bug#32423: 27.0.50; Compilation fails when sh points to zsh

[Tino Calancha]

I started to suffer this recently (~ since this month).
When
bin/sh points to /bin/zsh

I get an zsh parse error as follows:

make[2]: Entering directory '/home/calancha/soft/emacs-master/admin/grammars'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/calancha/soft/emacs-master/admin/grammars'
zsh:8: parse error near `done'
make[2]: Entering directory '/home/calancha/soft/emacs-master/leim'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/calancha/soft/emacs-master/leim'
Makefile:338: recipe for target 'compile-clean' failed
make[1]: *** [compile-clean] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/home/calancha/soft/emacs-master/lisp'
Makefile:405: recipe for target 'lisp' failed
make: *** [lisp] Error 2

bug#32423: 27.0.50; Compilation fails when sh points to zsh

[Eli Zaretskii]

> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Sun, 12 Aug 2018 02:28:23 +0900
> 
> 
> I started to suffer this recently (~ since this month).
> When
> bin/sh points to /bin/zsh
> 
> I get an zsh parse error as follows:
> 
> make[2]: Entering directory '/home/calancha/soft/emacs-master/admin/grammars'
> make[2]: Nothing to be done for 'all'.
> make[2]: Leaving directory '/home/calancha/soft/emacs-master/admin/grammars'
> zsh:8: parse error near `done'
> make[2]: Entering directory '/home/calancha/soft/emacs-master/leim'
> make[2]: Nothing to be done for 'all'.
> make[2]: Leaving directory '/home/calancha/soft/emacs-master/leim'
> Makefile:338: recipe for target 'compile-clean' failed

In the marked line:

compile-clean:
        @cd $(lisp) && \
        elcs=`echo "${SUBDIRS_REL} " | sed -e 's|/\./|/|g' -e 's|/\. | |g' -e 's| |/*.elc |g'`; \
        for el in `echo $$elcs | sed -e 's/\.elc/\.el/g'`; do \
          if test -f "$$el" || test ! -f "$${el}c"; then :; else \
            echo rm "$${el}c"; \
            rm "$${el}c"; \
          fi \  <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
        done

there should be a semi-colon after "fi", I believe.  If you make that
change, does the problem go away for you?

bug#32423: 27.0.50; Compilation fails when sh points to zsh

[Tino Calancha]

Eli Zaretskii <eliz@gnu.org> writes:

> compile-clean:
>         @cd $(lisp) && \
>         elcs=`echo "${SUBDIRS_REL} " | sed -e 's|/\./|/|g' -e 's|/\. | |g' -e 's| |/*.elc |g'`; \
>         for el in `echo $$elcs | sed -e 's/\.elc/\.el/g'`; do \
>           if test -f "$$el" || test ! -f "$${el}c"; then :; else \
>             echo rm "$${el}c"; \
>             rm "$${el}c"; \
>           fi \  <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
>         done
>
> there should be a semi-colon after "fi", I believe.  If you make that
> change, does the problem go away for you?
Excellent catch! It fixes the problem:
(I didn't know zsh is such picky shell)

diff --git a/lisp/Makefile.in b/lisp/Makefile.in
index ccc5323b52..c447598298 100644
--- a/lisp/Makefile.in
+++ b/lisp/Makefile.in
@@ -341,7 +341,7 @@ compile-clean:
 	  if test -f "$$el" || test ! -f "$${el}c"; then :; else \
 	    echo rm "$${el}c"; \
 	    rm "$${el}c"; \
-	  fi \
+	  fi; \
 	done
 
 .PHONY: gen-lisp leim semantic

bug#32423: 27.0.50; Compilation fails when sh points to zsh

[Tino Calancha]

Tino Calancha <tino.calancha@gmail.com> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>> compile-clean:
>>         @cd $(lisp) && \
>>         elcs=`echo "${SUBDIRS_REL} " | sed -e 's|/\./|/|g' -e 's|/\. | |g' -e 's| |/*.elc |g'`; \
>>         for el in `echo $$elcs | sed -e 's/\.elc/\.el/g'`; do \
>>           if test -f "$$el" || test ! -f "$${el}c"; then :; else \
>>             echo rm "$${el}c"; \
>>             rm "$${el}c"; \
>>           fi \  <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
>>         done
>>
>> there should be a semi-colon after "fi", I believe.  If you make that
>> change, does the problem go away for you?
> Excellent catch! It fixes the problem:
Fixed in master branch as commit 'Fix typo caught by zsh'
(21c2fd724dcae8a2342f256a0dd8c3c78fb5e931)