From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33729: 27.0.50; Partial glyphs not rendered for Gujarati with Harfbuzz enabled (renders fine using m17n) Date: Sun, 27 Jan 2019 19:12:45 +0200 Message-ID: <83ftte3tyq.fsf@gnu.org> References: <83bm5d9wsc.fsf@gnu.org> <20181222205948.GF2244@macbook.localdomain> <838t0gapcj.fsf@gnu.org> <20181223135109.GA6568@macbook.localdomain> <83va3k8c79.fsf@gnu.org> <20181224020847.GC6568@macbook.localdomain> <83lg4e9a7q.fsf@gnu.org> <20181224173723.GH6568@macbook.localdomain> <838t085qx8.fsf@gnu.org> <20190105205314.GA28761@macbook.localdomain> <20190105210420.GA31354@macbook.localdomain> <83pnt9zn73.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="86271"; mail-complaints-to="usenet@blaine.gmane.org" Cc: behdad@behdad.org, far.nasiri.m@gmail.com, 33729@debbugs.gnu.org To: dr.khaled.hosny@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 27 18:29:57 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gnoFn-000MDy-VE for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Jan 2019 18:29:56 +0100 Original-Received: from localhost ([127.0.0.1]:48449 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gnoFm-0000SB-Qw for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Jan 2019 12:29:54 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gnoEk-0007pW-6P for bug-gnu-emacs@gnu.org; Sun, 27 Jan 2019 12:28:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gno0Q-0002bb-Gk for bug-gnu-emacs@gnu.org; Sun, 27 Jan 2019 12:14:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48559) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gno0Q-0002bW-Cb for bug-gnu-emacs@gnu.org; Sun, 27 Jan 2019 12:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gno0Q-0001wP-5N for bug-gnu-emacs@gnu.org; Sun, 27 Jan 2019 12:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Jan 2019 17:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33729 X-GNU-PR-Package: emacs Original-Received: via spool by 33729-submit@debbugs.gnu.org id=B33729.15486091887384 (code B ref 33729); Sun, 27 Jan 2019 17:14:02 +0000 Original-Received: (at 33729) by debbugs.gnu.org; 27 Jan 2019 17:13:08 +0000 Original-Received: from localhost ([127.0.0.1]:47840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gnnzY-0001v1-2j for submit@debbugs.gnu.org; Sun, 27 Jan 2019 12:13:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gnnzW-0001uU-LN for 33729@debbugs.gnu.org; Sun, 27 Jan 2019 12:13:06 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36682) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gnnzR-0001uk-Hq; Sun, 27 Jan 2019 12:13:01 -0500 Original-Received: from [176.228.60.248] (port=1412 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gnnzR-0000az-5G; Sun, 27 Jan 2019 12:13:01 -0500 In-reply-to: <83pnt9zn73.fsf@gnu.org> (message from Eli Zaretskii on Sun, 06 Jan 2019 19:54:24 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154820 Archived-At: > Date: Sun, 06 Jan 2019 19:54:24 +0200 > From: Eli Zaretskii > Cc: behdad@behdad.org, far.nasiri.m@gmail.com, 33729@debbugs.gnu.org > > > Date: Sat, 5 Jan 2019 23:04:20 +0200 > > From: Khaled Hosny > > Cc: far.nasiri.m@gmail.com, behdad@behdad.org, 33729@debbugs.gnu.org > > > > I pushed a couple of commits that does this based on my limited > > understanding of Emacs code, please check. > > Can you explain why you moved the call to > hb_buffer_guess_segment_properties _after_ the code which sets some of > the properties? I cannot find anything about that in the HarfBuzz > documentation. Is this because guessing the unset properties can > benefit from knowing the properties which _are_ set, such as the > direction? > > I did it the other way around, because my mental model was: first set > the defaults, then override them where better info is available. > > Thanks. Please respond.