From: Eli Zaretskii <eliz@gnu.org>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: 34215@debbugs.gnu.org
Subject: bug#34215: 27.0.50; Provide elisp access to Chinese pinyin-to-character mapping
Date: Wed, 30 Jan 2019 19:09:47 +0200 [thread overview]
Message-ID: <83ftta138k.fsf@gnu.org> (raw)
In-Reply-To: <87va27cq35.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Tue, 29 Jan 2019 09:48:30 -0800)
> From: Eric Abrahamsen <eric@ericabrahamsen.net>
> Date: Tue, 29 Jan 2019 09:48:30 -0800
>
> I've attached a diff adding the conversion function itself, but I'm not
> familiar with makefiles and so far haven't been able to figure out how
> to call it. It looks like the invocation I want will look like:
>
> $(AM_V_GEN)${RUN_EMACS} -l titdic-cnv -f pinyin-convert \
> ${srcdir}/MISC-DIC/pinyin.map ${srcdir}/../lisp/language/pinyin.el
>
> Where ${srcdir} is the leim directory, but I don't actually know how to
> get this code called by make...
Add a target that is the file produced by this command, then make the
above command the recipe of that target. Similar to the
${leimdir}/ja-dic/ja-dic.el target.
But if the above doesn't help, someone else could do this part for
you.
> > I understand, but I wonder if someone could try that for a while and
> > see if it makes better input method(s), before we decide to import it.
>
> FWIW, that mapping is used by the pyim package, which I believe is the
> most popular pinyin-based Chinese input method out there. I also use it
> via the system-wide input framework fcitx, and it works very well.
Then I guess we will be fine importing the new version.
> +(defun pinyin-convert ()
> + "Convert text file pinyin.map into an elisp library.
> +The library is named pinyin.el, and contains the constant
> +`pinyin-character-map'."
This writes out a .el file, but does it encode that file in UTF-8,
even if the locale's codeset is something other than UTF-8? If not,
you need to bind coding-system-for-write to UTF-8.
> + (insert ";; This file is automatically generated from pinyin.map,\
> + by the function pinyin-convert.")
This line is too long, suggest to break it in two.
> + (insert ")\n\"An alist holding correspondences between pinyin syllables\
> + and Chinese characters.\")\n")
Likewise here.
Thanks.
next prev parent reply other threads:[~2019-01-30 17:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 5:34 bug#34215: 27.0.50; Provide elisp access to Chinese pinyin-to-character mapping Eric Abrahamsen
2019-01-27 15:41 ` Eli Zaretskii
2019-01-27 18:02 ` Eric Abrahamsen
2019-01-27 18:14 ` Eli Zaretskii
2019-01-27 19:18 ` Eric Abrahamsen
2019-01-27 19:48 ` Eli Zaretskii
2019-01-29 17:48 ` Eric Abrahamsen
2019-01-30 17:09 ` Eli Zaretskii [this message]
2019-01-30 20:33 ` Eric Abrahamsen
2019-01-30 20:48 ` Eric Abrahamsen
2019-01-31 8:50 ` Robert Pluim
2019-01-31 19:35 ` Eric Abrahamsen
2019-02-01 9:48 ` Eli Zaretskii
2019-02-01 16:27 ` Eric Abrahamsen
2019-02-01 18:53 ` Eli Zaretskii
2019-02-01 19:15 ` Eric Abrahamsen
2019-02-24 5:36 ` Eric Abrahamsen
2019-02-24 16:06 ` Eli Zaretskii
2019-02-24 18:53 ` Eric Abrahamsen
2019-02-24 19:12 ` bug#34215: Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ftta138k.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=34215@debbugs.gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).