From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34290: [PATCH] checkdoc byte compile warnings Date: Sat, 02 Feb 2019 18:35:27 +0200 Message-ID: <83ftt6w3lc.fsf@gnu.org> References: <87zhre9opq.fsf@gmail.com> <83imy2w4xt.fsf@gnu.org> <87womi9mua.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="45783"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34290@debbugs.gnu.org To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 02 17:37:29 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gpyIL-000BoQ-3u for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Feb 2019 17:37:29 +0100 Original-Received: from localhost ([127.0.0.1]:44106 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpyIK-0001F7-04 for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Feb 2019 11:37:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpyI8-0001Ep-Fs for bug-gnu-emacs@gnu.org; Sat, 02 Feb 2019 11:37:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gpyI7-000845-Be for bug-gnu-emacs@gnu.org; Sat, 02 Feb 2019 11:37:16 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57266) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gpyHu-0007sC-4S for bug-gnu-emacs@gnu.org; Sat, 02 Feb 2019 11:37:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gpyHt-0007Pu-WA for bug-gnu-emacs@gnu.org; Sat, 02 Feb 2019 11:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Feb 2019 16:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34290 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34290-submit@debbugs.gnu.org id=B34290.154912537028443 (code B ref 34290); Sat, 02 Feb 2019 16:37:01 +0000 Original-Received: (at 34290) by debbugs.gnu.org; 2 Feb 2019 16:36:10 +0000 Original-Received: from localhost ([127.0.0.1]:56547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpyH3-0007Oh-Nc for submit@debbugs.gnu.org; Sat, 02 Feb 2019 11:36:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpyH2-0007OU-1K for 34290@debbugs.gnu.org; Sat, 02 Feb 2019 11:36:08 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41453) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpyGo-0006fG-NA; Sat, 02 Feb 2019 11:35:54 -0500 Original-Received: from [176.228.60.248] (port=3436 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gpyGm-0003zR-Qb; Sat, 02 Feb 2019 11:35:54 -0500 In-reply-to: <87womi9mua.fsf@gmail.com> (message from Alex Branham on Sat, 02 Feb 2019 10:28:13 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155026 Archived-At: > From: Alex Branham > Cc: 34290@debbugs.gnu.org > Date: Sat, 02 Feb 2019 10:28:13 -0600 > > On Sat 02 Feb 2019 at 10:06, Eli Zaretskii wrote: > > > AFAIU, declare-function is useful when the function in question is > > auto-loaded, but we don't want to load its package unconditionally, > > e.g. because that function is used only in a small part of the package > > being compiled. None of which seems to be the case here, or did I > > miss something? > > I was just following with what the file was already doing. More than > happy to require lisp-mnt top-level though, patch attached. Thanks, this looks good. Let's wait for a few days for additional comments, if someone would like to voice them.