From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35507: Gnus mojibakifies UTF-8 text/x-patch attachments from Thunderbird Date: Thu, 02 May 2019 18:57:23 +0300 Message-ID: <83ftpwq270.fsf@gnu.org> References: <44a26585-7980-378c-9262-a567ddd3e617@cs.ucla.edu> <865zqv3tc2.fsf@gmail.com> <838svqqdp2.fsf@gnu.org> <87d0l1o8p7.fsf@gmail.com> <86v9ytz5nk.fsf@gmail.com> <2133CEDA-748F-44F0-901B-D7213645369A@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="171940"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35507@debbugs.gnu.org To: Andy Moreton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 02 17:58:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hME66-000iay-8g for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 May 2019 17:58:10 +0200 Original-Received: from localhost ([127.0.0.1]:53556 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hME65-0004gi-4c for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 May 2019 11:58:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hME5z-0004gb-4I for bug-gnu-emacs@gnu.org; Thu, 02 May 2019 11:58:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hME5y-0002W1-4s for bug-gnu-emacs@gnu.org; Thu, 02 May 2019 11:58:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33246) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hME5x-0002Ud-Ss for bug-gnu-emacs@gnu.org; Thu, 02 May 2019 11:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hME5x-0007BO-KA; Thu, 02 May 2019 11:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Thu, 02 May 2019 15:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35507 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 35507-submit@debbugs.gnu.org id=B35507.155681267227594 (code B ref 35507); Thu, 02 May 2019 15:58:01 +0000 Original-Received: (at 35507) by debbugs.gnu.org; 2 May 2019 15:57:52 +0000 Original-Received: from localhost ([127.0.0.1]:46790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hME5n-0007Az-PR for submit@debbugs.gnu.org; Thu, 02 May 2019 11:57:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hME5l-0007Al-D0 for 35507@debbugs.gnu.org; Thu, 02 May 2019 11:57:49 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hME5g-0002KR-6k; Thu, 02 May 2019 11:57:44 -0400 Original-Received: from [176.228.60.248] (port=4157 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hME5f-0002We-30; Thu, 02 May 2019 11:57:43 -0400 In-reply-to: (message from Andy Moreton on Thu, 02 May 2019 16:43:31 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158643 Archived-At: > From: Andy Moreton > Date: Thu, 02 May 2019 16:43:31 +0100 > > > So yes, I think Noam is right, and 'undecided' is a better alternative here. > > That is arguing for the existing code, which does not work correctly. No, the existing code simply uses the undecoded string. What I argue for is to do this: diff --git a/lisp/gnus/mm-view.el b/lisp/gnus/mm-view.el index 1e1d264b99..173ebfab48 100644 --- a/lisp/gnus/mm-view.el +++ b/lisp/gnus/mm-view.el @@ -475,7 +475,7 @@ mm-display-inline-fontify (charset (mm-decode-string text charset)) (t - text))) + (mm-decode-string text 'undecided)))) (let ((font-lock-verbose nil) ; font-lock is a bit too verbose. (enable-local-variables nil)) ;; We used to set font-lock-mode-hook to nil to avoid enabling > I am disinclined to look any further at this, as nobody else appears to > be running the existing code before commenting, or testing the proposed > patch. Please don't be offended, there's no intent to offend you here. Your efforts are greatly appreciated. We are just discussing a small change to what you were proposing, see above. Or are you saying that using undecided as above doesn't do the job? (Sorry, I don't use Gnus, so to be able to reproduce the problem and test a proposed solution I need detailed instructions, I cannot easily do it myself without investing an inordinate amount of time.)