From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] Date: Wed, 12 Jun 2019 19:07:29 +0300 Message-ID: <83ftoe948u.fsf@gnu.org> References: <1560263874.21373.1@yandex.ru> <5f7ea771-2a22-ba10-b3ce-6adb5e85dc9d@cs.ucla.edu> <85476B58-4CBD-45C9-903C-5E49D8E5D019@acm.org> <83zhmo834p.fsf@gnu.org> <5e87c0dd-1554-4192-b7c1-00212e0be1e0@default> <83wohs81qj.fsf@gnu.org> <83pnnj8rin.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="260574"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36167@debbugs.gnu.org To: Andy Moreton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 12 18:10:54 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hb5pu-0015e1-7f for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Jun 2019 18:10:54 +0200 Original-Received: from localhost ([::1]:33608 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hb5pt-0001Jf-97 for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Jun 2019 12:10:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47916) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hb5nA-0007et-Va for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2019 12:08:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hb5n9-0003Nd-OI for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2019 12:08:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48635) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hb5n9-0003NJ-IK for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2019 12:08:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hb5n8-0003ia-5j for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2019 12:08:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2019 16:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156035566114259 (code B ref 36167); Wed, 12 Jun 2019 16:08:02 +0000 Original-Received: (at 36167) by debbugs.gnu.org; 12 Jun 2019 16:07:41 +0000 Original-Received: from localhost ([127.0.0.1]:33946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb5mn-0003hv-Hv for submit@debbugs.gnu.org; Wed, 12 Jun 2019 12:07:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb5mk-0003he-AI for 36167@debbugs.gnu.org; Wed, 12 Jun 2019 12:07:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41859) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hb5me-0002xD-LS; Wed, 12 Jun 2019 12:07:32 -0400 Original-Received: from [176.228.60.248] (port=1460 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hb5md-0002zj-RX; Wed, 12 Jun 2019 12:07:32 -0400 In-reply-to: (message from Andy Moreton on Wed, 12 Jun 2019 12:44:12 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160451 Archived-At: > From: Andy Moreton > Date: Wed, 12 Jun 2019 12:44:12 +0100 > > >> The [:alnum:] and [:alpha:] are based on (unspecified values of) the Unicode > >> general-category property, but [:digit:] is not. Thus [:alnum:] includes > >> other numeric characters that are not matched by [:digit:]. > > > > It's true that [:alnum:] includes more numerical characters that > > [:digit:], but what exactly needs to be clarified here? Assuming you > > mean clarified in the manual, that is. > > As noted by Paul Eggert, the POSIX behaviour is different. It may be > worth a note in the manual to draw attention to this difference. It's strange to say in the manual what we do NOT do. The current text says: ‘[:digit:]’ This matches ‘0’ through ‘9’. Thus, ‘[-+[:digit:]]’ matches any digit, as well as ‘+’ and ‘-’. I believe you suggest to add to this something like "Note that Posix interpretation of '[:digit:]' is different"? Given the crystal clarity of the current text, wouldn't such addition confuse the reader? Btw, where's the reference for a different interpretation by Posix? I cannot find anything to that effect; even the Unicode UTS18 (http://www.unicode.org/reports/tr18/) says, while describing the Posix equivalent of the Unicode regexp notations: "Non-decimal numbers (like Roman numerals) are normally excluded". What am I missing?