From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36591: 26.2; Term's pager seems broken Date: Thu, 25 Jul 2019 16:11:15 +0300 Message-ID: <83ftmuntsc.fsf@gnu.org> References: <87lfwox3fi.fsf@gmail.com> <838ssops2u.fsf@gnu.org> <87imrsw5gj.fsf@gmail.com> <83y30no4hi.fsf@gnu.org> <87ftmvvsol.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="27304"; mail-complaints-to="usenet@blaine.gmane.org" Cc: larsi@gnus.org, abliss@gmail.com, 36591@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 25 15:12:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hqdXX-0006zv-3Y for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Jul 2019 15:12:11 +0200 Original-Received: from localhost ([::1]:60042 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqdXW-0000gT-2Z for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Jul 2019 09:12:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45045) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqdXT-0000gB-G7 for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2019 09:12:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hqdXO-0007Jd-MH for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2019 09:12:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57982) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hqdXO-0007JX-Ir for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2019 09:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hqdXO-0003jp-Ag for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2019 09:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jul 2019 13:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36591 X-GNU-PR-Package: emacs Original-Received: via spool by 36591-submit@debbugs.gnu.org id=B36591.156406028914327 (code B ref 36591); Thu, 25 Jul 2019 13:12:02 +0000 Original-Received: (at 36591) by debbugs.gnu.org; 25 Jul 2019 13:11:29 +0000 Original-Received: from localhost ([127.0.0.1]:38570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqdWr-0003j1-3l for submit@debbugs.gnu.org; Thu, 25 Jul 2019 09:11:29 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqdWp-0003ip-US for 36591@debbugs.gnu.org; Thu, 25 Jul 2019 09:11:28 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hqdWk-00077V-OK; Thu, 25 Jul 2019 09:11:22 -0400 Original-Received: from [176.228.60.248] (port=1465 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hqdWj-0005hS-IV; Thu, 25 Jul 2019 09:11:22 -0400 In-reply-to: <87ftmvvsol.fsf@gmail.com> (message from Noam Postavsky on Wed, 24 Jul 2019 20:55:38 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163707 Archived-At: > From: Noam Postavsky > Cc: Lars Ingebrigtsen , abliss@gmail.com, 36591@debbugs.gnu.org > Date: Wed, 24 Jul 2019 20:55:38 -0400 > > > I would like to leave connect_network_socket alone on the release > > branch, and just fix the problem with set-process-filter. I think the > > easiest way is simply not to call set_process_filter_masks in > > set-process-filter, and instead restore the way that code worked > > before 9755b753, i.e. let it test the argument FILTER _before_ that > > filter is installed. Do you see any problems with this fix? > > I think that makes sense, patch attached. Thanks, this patch is OK for the emacs-26 branch. > > On the master branch we should clean up the confusing set of if > > clauses, both in set-process-filter and in connect_network_socket. > > Perhaps Lars could describe his reasoning for making the change which > > introduced set_process_filter_masks and what problem it tried to > > solve. (Btw, the log message for that change seems to imply that > > set-process-filter should not have called set_process_filter_masks, > > something that the change itself disagrees with. An omission?) > > Hmm, true, I didn't pay that close attention to the log message. > Maybe "we may not have a socket yet" refers to the already existing > 'if (p->infd >= 0)' check? Let's see what Lars remembers, and let's then take it from there.