From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37415: Asserting failure setting frame parameters to non-fixnum values in early-init.el Date: Sat, 21 Sep 2019 15:27:46 +0300 Message-ID: <83ftkprfzx.fsf@gnu.org> References: <83v9tqvrm7.fsf@gnu.org> <9aae1b2e-bb5f-8634-5501-9aaff9f51266@gmx.at> <83imppvl9r.fsf@gnu.org> <14d4a455-254e-fdc2-0b64-791cfb0f7724@gmx.at> <83o8zgtlvq.fsf@gnu.org> <0936d492-c2bc-d4d3-7fcf-272d0fdbe087@gmx.at> <83a7ayss4b.fsf@gnu.org> <7b896377-d546-b428-adba-797ec988c4fa@gmx.at> <83r24aqadz.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="84591"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37415@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 21 14:28:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iBeUk-000Lp4-Fd for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Sep 2019 14:28:10 +0200 Original-Received: from localhost ([::1]:41618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iBeUi-0005X2-QV for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Sep 2019 08:28:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54732) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iBeUd-0005Wt-3r for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2019 08:28:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iBeUc-0006MP-51 for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2019 08:28:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50484) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iBeUb-0006ML-UO for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2019 08:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iBeUb-0000i8-PH for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2019 08:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Sep 2019 12:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37415 X-GNU-PR-Package: emacs Original-Received: via spool by 37415-submit@debbugs.gnu.org id=B37415.15690688662709 (code B ref 37415); Sat, 21 Sep 2019 12:28:01 +0000 Original-Received: (at 37415) by debbugs.gnu.org; 21 Sep 2019 12:27:46 +0000 Original-Received: from localhost ([127.0.0.1]:59305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBeUM-0000hd-Jd for submit@debbugs.gnu.org; Sat, 21 Sep 2019 08:27:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46235) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBeUL-0000hO-4C for 37415@debbugs.gnu.org; Sat, 21 Sep 2019 08:27:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43318) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iBeUF-0006Cz-PL; Sat, 21 Sep 2019 08:27:39 -0400 Original-Received: from [176.228.60.248] (port=3874 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iBeUE-00021V-OH; Sat, 21 Sep 2019 08:27:39 -0400 In-reply-to: (message from Juanma Barranquero on Sat, 21 Sep 2019 12:02:51 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166875 Archived-At: > From: Juanma Barranquero > Date: Sat, 21 Sep 2019 12:02:51 +0200 > Cc: martin rudalics , 37415@debbugs.gnu.org > > Before 572fe798cd0a00ad4a9050a7962cf8e8fbcc209b (from 2014-09-30), the computation of left and top > was done in w32_createwindow: > > /* When called with RES_TYPE_NUMBER, w32_get_arg will return zero > for anything that is not a number and is not Qunbound. */ > left = x_get_arg (dpyinfo, Qnil, Qleft, "left", "Left", RES_TYPE_NUMBER); > top = x_get_arg (dpyinfo, Qnil, Qtop, "top", "Top", RES_TYPE_NUMBER); > > and anything not a number was turned to 0. > > In that commit you moved the code to my_create_window and used XINT: > > + /* When called with RES_TYPE_NUMBER, x_get_arg will return zero for > + anything that is not a number and is not Qunbound. */ > + left = x_get_arg (dpyinfo, Qnil, Qleft, "left", "Left", RES_TYPE_NUMBER); > + top = x_get_arg (dpyinfo, Qnil, Qtop, "top", "Top", RES_TYPE_NUMBER); > + if (EQ (left, Qunbound)) > + coords[0] = CW_USEDEFAULT; > + else > + coords[0] = XINT (left); > + if (EQ (top, Qunbound)) > + coords[1] = CW_USEDEFAULT; > + else > + coords[1] = XINT (top); > + Yes, but contrary to the comment, in the case in point we don't get zero from x_get_arg. Which is why I asked all those questions.