unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 37415@debbugs.gnu.org
Subject: bug#37415: Asserting failure setting frame parameters to non-fixnum values in early-init.el
Date: Sat, 21 Sep 2019 15:27:46 +0300	[thread overview]
Message-ID: <83ftkprfzx.fsf@gnu.org> (raw)
In-Reply-To: <CAAeL0SQv9C=fzgacL=KRe+pT4PaSVjmRa+dRW-fbPHcxYJWmxA@mail.gmail.com> (message from Juanma Barranquero on Sat, 21 Sep 2019 12:02:51 +0200)

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Sat, 21 Sep 2019 12:02:51 +0200
> Cc: martin rudalics <rudalics@gmx.at>, 37415@debbugs.gnu.org
> 
> Before 572fe798cd0a00ad4a9050a7962cf8e8fbcc209b (from 2014-09-30), the computation of left and top
> was done in w32_createwindow:
> 
>       /* When called with RES_TYPE_NUMBER, w32_get_arg will return zero
>         for anything that is not a number and is not Qunbound.  */
>       left = x_get_arg (dpyinfo, Qnil, Qleft, "left", "Left", RES_TYPE_NUMBER);
>       top = x_get_arg (dpyinfo, Qnil, Qtop, "top", "Top", RES_TYPE_NUMBER);
> 
> and anything not a number was turned to 0.
> 
> In that commit you moved the code to my_create_window and used XINT:
> 
>  +  /* When called with RES_TYPE_NUMBER, x_get_arg will return zero for
>  +     anything that is not a number and is not Qunbound.  */
>  +  left = x_get_arg (dpyinfo, Qnil, Qleft, "left", "Left", RES_TYPE_NUMBER);
>  +  top = x_get_arg (dpyinfo, Qnil, Qtop, "top", "Top", RES_TYPE_NUMBER);
>  +  if (EQ (left, Qunbound))
>  +    coords[0] = CW_USEDEFAULT;
>  +  else
>  +    coords[0] = XINT (left);
>  +  if (EQ (top, Qunbound))
>  +    coords[1] = CW_USEDEFAULT;
>  +  else
>  +    coords[1] = XINT (top);
>  +

Yes, but contrary to the comment, in the case in point we don't get
zero from x_get_arg.  Which is why I asked all those questions.





  reply	other threads:[~2019-09-21 12:27 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-15 22:34 bug#37415: Asserting failure setting frame parameters to non-fixnum values in early-init.el Juanma Barranquero
2019-09-17 16:01 ` Eli Zaretskii
2019-09-17 17:04   ` Juanma Barranquero
2019-09-18  7:45   ` martin rudalics
2019-09-18 12:31     ` Eli Zaretskii
2019-09-19  8:17       ` martin rudalics
2019-09-19 14:13         ` Eli Zaretskii
2019-09-20  8:13           ` martin rudalics
2019-09-20 19:08             ` Eli Zaretskii
2019-09-21  8:51               ` martin rudalics
2019-09-21  9:14                 ` Eli Zaretskii
2019-09-21 10:02                   ` Juanma Barranquero
2019-09-21 12:27                     ` Eli Zaretskii [this message]
2019-09-22  5:54                       ` Juanma Barranquero
2019-09-22  8:09                         ` martin rudalics
2019-09-22 16:26                         ` Eli Zaretskii
2019-09-22  8:08                       ` martin rudalics
2019-09-22 16:43                         ` Eli Zaretskii
2019-09-22 17:54                           ` martin rudalics
2019-09-22 18:19                             ` Eli Zaretskii
2019-09-23  7:32                               ` martin rudalics
2019-09-23 16:35                                 ` Eli Zaretskii
2019-09-24  6:45                                   ` martin rudalics
2019-09-24  7:41                                     ` Eli Zaretskii
2019-09-22  8:08                   ` martin rudalics
2019-09-22 16:27                     ` Eli Zaretskii
2019-09-22 17:53                       ` martin rudalics
2019-09-22 18:16                         ` Eli Zaretskii
2019-09-23  7:32                           ` martin rudalics
2019-09-23 16:08                             ` Eli Zaretskii
2019-09-21  4:25             ` Juanma Barranquero
2019-09-18  2:30 ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ftkprfzx.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=37415@debbugs.gnu.org \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).