From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0) Date: Wed, 19 Feb 2020 17:39:22 +0200 Message-ID: <83ftf6lh79.fsf@gnu.org> References: <87h7zoorys.fsf@thb.lt> <87lfozsuoi.fsf@thb.lt> <83pneblloc.fsf@gnu.org> <83lfozlkmt.fsf@gnu.org> <8c68006d-54b5-7fd5-128a-c253b4899cde@yandex.ru> <83k14jl0j8.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="97828"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39662@debbugs.gnu.org, thibault@thb.lt, dgutov@yandex.ru To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 19 16:40:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j4RSO-000PJN-Aa for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Feb 2020 16:40:12 +0100 Original-Received: from localhost ([::1]:54708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4RSN-0004fb-Bn for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Feb 2020 10:40:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60871) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4RSF-0004fC-C6 for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 10:40:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4RSE-00014l-I6 for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 10:40:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37289) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j4RSE-00014f-ES for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 10:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j4RSE-0004Tr-B4 for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 10:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Feb 2020 15:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39662 X-GNU-PR-Package: emacs Original-Received: via spool by 39662-submit@debbugs.gnu.org id=B39662.158212678517193 (code B ref 39662); Wed, 19 Feb 2020 15:40:02 +0000 Original-Received: (at 39662) by debbugs.gnu.org; 19 Feb 2020 15:39:45 +0000 Original-Received: from localhost ([127.0.0.1]:43262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4RRx-0004TF-DE for submit@debbugs.gnu.org; Wed, 19 Feb 2020 10:39:45 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4RRv-0004T1-U6 for 39662@debbugs.gnu.org; Wed, 19 Feb 2020 10:39:44 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39794) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j4RRq-0000kq-D4; Wed, 19 Feb 2020 10:39:38 -0500 Original-Received: from [176.228.60.248] (port=4979 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j4RRp-00053W-P2; Wed, 19 Feb 2020 10:39:38 -0500 In-reply-to: (message from Robert Pluim on Wed, 19 Feb 2020 09:59:21 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176249 Archived-At: > From: Robert Pluim > Date: Wed, 19 Feb 2020 09:59:21 +0100 > Cc: Dmitry Gutov , Thibault Polge , 39662@debbugs.gnu.org > > If the user turns fringe-mode back on, diff-hl will use the previously created bitmaps, which will be width 1 if > define-fringe-bitmap decides to use that instead of zero, or will crash if x_cr_define_fringe_bitmap does not > define the bitmap when width == 0 Since passing zero invokes undefined behavior, producing 1 from that is fine. Crashing is best avoided, though. > Maybe signaling an error is best :-) That was my original suggestion/tendency, so I obviously agree. Thanks.