unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: 39662@debbugs.gnu.org, thibault@thb.lt, dgutov@yandex.ru
Subject: bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0)
Date: Wed, 19 Feb 2020 17:39:22 +0200	[thread overview]
Message-ID: <83ftf6lh79.fsf@gnu.org> (raw)
In-Reply-To: <CAMTcmTc8hE0Z6ov-LFF-V7S=DrvhToGnMaD4SaFeL-MzM+9rjQ@mail.gmail.com> (message from Robert Pluim on Wed, 19 Feb 2020 09:59:21 +0100)

> From: Robert Pluim <rpluim@gmail.com>
> Date: Wed, 19 Feb 2020 09:59:21 +0100
> Cc: Dmitry Gutov <dgutov@yandex.ru>, Thibault Polge <thibault@thb.lt>, 39662@debbugs.gnu.org
> 
> If the user turns fringe-mode back on, diff-hl will use the previously created bitmaps, which will be width 1 if
> define-fringe-bitmap decides to use that instead of zero, or will crash if x_cr_define_fringe_bitmap does not
> define the bitmap when width == 0

Since passing zero invokes undefined behavior, producing 1 from that
is fine.  Crashing is best avoided, though.

> Maybe signaling an error is best :-)

That was my original suggestion/tendency, so I obviously agree.

Thanks.





  reply	other threads:[~2020-02-19 15:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-18 15:06 bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0) Thibault Polge
2020-02-18 15:45 ` Robert Pluim
2020-02-18 16:54   ` Thibault Polge
2020-02-18 19:32     ` Robert Pluim
2020-02-18 19:50       ` Eli Zaretskii
2020-02-18 20:03         ` Robert Pluim
2020-02-18 20:12           ` Eli Zaretskii
2020-02-18 20:29             ` Dmitry Gutov
2020-02-18 20:34               ` Robert Pluim
2020-02-18 21:32                 ` Dmitry Gutov
2020-02-19  3:27               ` Eli Zaretskii
2020-02-19  8:59                 ` Robert Pluim
2020-02-19 15:39                   ` Eli Zaretskii [this message]
2020-02-26  9:56                     ` Robert Pluim
2020-02-26 14:27                       ` Dmitry Gutov
2020-02-26 15:27                         ` Robert Pluim
2020-02-26 17:55                           ` Eli Zaretskii
2020-02-26 18:36                             ` Robert Pluim
2020-02-18 19:29   ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ftf6lh79.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=39662@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=rpluim@gmail.com \
    --cc=thibault@thb.lt \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).