From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE Date: Sun, 05 Apr 2020 05:37:03 +0300 Message-ID: <83ftdiu08g.fsf@gnu.org> References: <805F9723-8298-4FD7-A47B-1E683721A5B0@acm.org> <835zegwn9y.fsf@gnu.org> <83mu7rvbyk.fsf@gnu.org> <729DE2D1-EA0F-46F9-8B4B-2ED146CE6892@acm.org> <83pncntbc2.fsf@gnu.org> <83o8s7tams.fsf@gnu.org> <0D7F6CFF-89DB-4A0F-8F4C-3F0C7E7235D8@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="36278"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 40407@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 05 04:38:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jKvAr-0009L5-AX for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Apr 2020 04:38:13 +0200 Original-Received: from localhost ([::1]:43966 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKvAp-0003Il-W7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Apr 2020 22:38:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59534) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKvAh-0003IZ-M1 for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2020 22:38:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKvAg-0002JZ-KX for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2020 22:38:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33466) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jKvAg-0002JO-Hc for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2020 22:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jKvAg-00044i-DY for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2020 22:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Apr 2020 02:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40407 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 40407-submit@debbugs.gnu.org id=B40407.158605424115538 (code B ref 40407); Sun, 05 Apr 2020 02:38:02 +0000 Original-Received: (at 40407) by debbugs.gnu.org; 5 Apr 2020 02:37:21 +0000 Original-Received: from localhost ([127.0.0.1]:45012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKvA0-00042Y-Jb for submit@debbugs.gnu.org; Sat, 04 Apr 2020 22:37:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKv9y-00042K-Ju for 40407@debbugs.gnu.org; Sat, 04 Apr 2020 22:37:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jKv9s-0001lP-Bm; Sat, 04 Apr 2020 22:37:12 -0400 Original-Received: from [176.228.60.248] (port=4061 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jKv9r-00086L-QC; Sat, 04 Apr 2020 22:37:12 -0400 In-Reply-To: <0D7F6CFF-89DB-4A0F-8F4C-3F0C7E7235D8@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Sat, 4 Apr 2020 20:06:23 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178048 Archived-At: > From: Mattias Engdegård > Date: Sat, 4 Apr 2020 20:06:23 +0200 > Cc: 40407@debbugs.gnu.org > > 4 apr. 2020 kl. 19.37 skrev Eli Zaretskii : > > > Btw, if we want this particular use case to be as fast as possible, > > then Fcopy_sequence is not the best way, because it is not optimized > > for the case of copying a single string. We could do better by > > calling make_uninit_multibyte/unibyte_string and memcpy directly. > > Yes, if that would provide a benefit. The pattern should probably be encapsulated in copy_string or similar, if it doesn't already exist. I wouldn't make it a separate function for the benefit of just one caller. Every function call is a slowdown, albeit a small one. > (Should it copy properties? Probably not.) Definitely not.