From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#40808: 27.0.91; inaccuracy in isearch-lazy-count Date: Wed, 29 Apr 2020 10:11:43 +0300 Message-ID: <83ftcm22c0.fsf@gnu.org> References: <41ce1bd9-2ddb-a46b-3cb9-2b1b25e48438@net-c.com> <87ftcrux08.fsf@mail.linkov.net> <83o8rb1kra.fsf@gnu.org> <87mu6vkvz5.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="15396"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 40808@debbugs.gnu.org, abdullah@net-c.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 29 09:13:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jTgu7-0003vN-15 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Apr 2020 09:13:11 +0200 Original-Received: from localhost ([::1]:35366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTgu5-0001o5-VK for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Apr 2020 03:13:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45096) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTgtz-0001nx-GO for bug-gnu-emacs@gnu.org; Wed, 29 Apr 2020 03:13:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTgtz-00053O-1j for bug-gnu-emacs@gnu.org; Wed, 29 Apr 2020 03:13:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58903) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTgty-00053H-MJ for bug-gnu-emacs@gnu.org; Wed, 29 Apr 2020 03:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jTgty-0002kg-H0 for bug-gnu-emacs@gnu.org; Wed, 29 Apr 2020 03:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Apr 2020 07:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40808 X-GNU-PR-Package: emacs Original-Received: via spool by 40808-submit@debbugs.gnu.org id=B40808.158814432910517 (code B ref 40808); Wed, 29 Apr 2020 07:13:02 +0000 Original-Received: (at 40808) by debbugs.gnu.org; 29 Apr 2020 07:12:09 +0000 Original-Received: from localhost ([127.0.0.1]:42216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTgt7-0002jZ-6V for submit@debbugs.gnu.org; Wed, 29 Apr 2020 03:12:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTgt5-0002jK-Kb for 40808@debbugs.gnu.org; Wed, 29 Apr 2020 03:12:08 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49379) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTgsz-0004rg-Pl; Wed, 29 Apr 2020 03:12:01 -0400 Original-Received: from [176.228.60.248] (port=4145 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jTgsy-0003ta-Tm; Wed, 29 Apr 2020 03:12:01 -0400 In-Reply-To: <87mu6vkvz5.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 29 Apr 2020 02:54:06 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179284 Archived-At: > From: Juri Linkov > Cc: Abdullah Asad , 40808@debbugs.gnu.org > Date: Wed, 29 Apr 2020 02:54:06 +0300 > > But there is still one corner case I'm worried about: > isearch-lazy-count still counts matches that can't be opened > and can't be visited, such as hidden links in org-mode. > > To not count them we need to bind 'search-invisible' to 'open' > in isearch-lazy-highlight-search, but the problem is that > isearch-filter-predicate and isearch-range-invisible will > temporarily open them, whereas we need just to check > whether they can be opened. > > So in the following patch I added a new variable isearch-check-overlays > that could instruct isearch-range-invisible to not open overlays > when it's non-nil that means we need only to check them, not open: Fine with me, but please make this change on master, not on emacs-27.