From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41890: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Date: Fri, 24 Jul 2020 19:12:39 +0300 Message-ID: <83ft9gevt4.fsf@gnu.org> References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> <874kq1d7wf.fsf@iris.silentflame.com> <87zh7s8mlv.fsf@mail.linkov.net> <87blk849lh.fsf@iris.silentflame.com> <87tuxz2vt8.fsf@iris.silentflame.com> <1d2621fe-2e06-cc2d-3c3f-b44d61427ac2@yandex.ru> <878sf9u0rm.fsf@iris.silentflame.com> <83sgdhe9jc.fsf@gnu.org> <871rl1t0aa.fsf@iris.silentflame.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34384"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41890@debbugs.gnu.org, 42210@debbugs.gnu.org, juri@linkov.net, contovob@tcd.ie, philip@warpmail.net, dgutov@yandex.ru To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 24 18:14:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jz0Ko-0008oX-1k for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Jul 2020 18:14:10 +0200 Original-Received: from localhost ([::1]:43644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jz0Km-000572-Vi for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Jul 2020 12:14:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48508) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jz0Kg-00056o-My for bug-gnu-emacs@gnu.org; Fri, 24 Jul 2020 12:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37059) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jz0Kg-0005oT-Cu for bug-gnu-emacs@gnu.org; Fri, 24 Jul 2020 12:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jz0Kg-0008M0-7v for bug-gnu-emacs@gnu.org; Fri, 24 Jul 2020 12:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Jul 2020 16:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41890 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41890-submit@debbugs.gnu.org id=B41890.159560719432051 (code B ref 41890); Fri, 24 Jul 2020 16:14:02 +0000 Original-Received: (at 41890) by debbugs.gnu.org; 24 Jul 2020 16:13:14 +0000 Original-Received: from localhost ([127.0.0.1]:48605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jz0Jq-0008Kl-Uf for submit@debbugs.gnu.org; Fri, 24 Jul 2020 12:13:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jz0Jj-0008K7-ND; Fri, 24 Jul 2020 12:13:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55397) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jz0Jc-0005dP-JO; Fri, 24 Jul 2020 12:12:56 -0400 Original-Received: from [176.228.60.248] (port=3004 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jz0Jb-000763-5a; Fri, 24 Jul 2020 12:12:56 -0400 In-Reply-To: <871rl1t0aa.fsf@iris.silentflame.com> (message from Sean Whitton on Fri, 24 Jul 2020 08:12:13 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183494 Archived-At: > From: Sean Whitton > Cc: dgutov@yandex.ru, juri@linkov.net, contovob@tcd.ie, philip@warpmail.net, > 41890@debbugs.gnu.org, 42210@debbugs.gnu.org > Date: Fri, 24 Jul 2020 08:12:13 -0700 > > > This interface strikes me as unusual and even unexpected for a command > > that switches to another buffer. I would expect it to have an API > > similar to that of switch-to-buffer: that it should accept the buffer > > to switch to as an argument, and set up that argument in the > > 'interactive' spec according to the preferences of this command > > (offering buffers in the same project etc.). The API you propose > > makes it awkward, to say the least, to invoke this command from Lisp. > > I added the argument just so I could reuse the code in > project-switch-to-buffer, so a simple alternative for the purposes of my > patch would be to factor that code out into a new > project--select-project-buffer defun. Then no existing APIs would be > changed. > > Would that be sufficient? What you added is not my problem, my problem is that there's no easy way of calling this function from Lisp. > > Granted, the original API doesn't allow such invocation, either, but > > as long as we are changing this API, let's try fixing that, okay? > > This is a bit tricky actually -- what should the function do if some > Lisp code passes it a buffer which is not part of the current project? Just switch to that buffer, I think.