From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36597: 27.0.50; rehash hash tables eagerly in pdumper Date: Wed, 12 Aug 2020 17:46:17 +0300 Message-ID: <83ft8rorba.fsf@gnu.org> References: <74235afc-7043-1da7-7c71-07f0ca23b9fd@cs.ucla.edu> <83r26mv53z.fsf@gnu.org> <87ft8vbow1.fsf@gnus.org> <87v9hq4ppp.fsf@gnus.org> <83k0y544lf.fsf@gnu.org> <8bf60d70-6b0d-0e07-fef9-9baad9d7749c@cs.ucla.edu> <837du5p17p.fsf@gnu.org> <63d00359-f7cc-5564-ecf0-d374dea979ff@cs.ucla.edu> <83zh71ni7r.fsf@gnu.org> <80399aee-a2ef-5d24-a19e-5ea615190cf9@cs.ucla.edu> <83pn7wneed.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31514"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 36597@debbugs.gnu.org, pipcet@gmail.com To: eggert@cs.ucla.edu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 12 16:47:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5s22-00084n-3v for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Aug 2020 16:47:10 +0200 Original-Received: from localhost ([::1]:44026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5s20-0001pq-Qi for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Aug 2020 10:47:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5s1u-0001pk-SZ for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2020 10:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33597) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k5s1u-0006Jn-HY for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2020 10:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k5s1u-00017h-El for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2020 10:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Aug 2020 14:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36597-submit@debbugs.gnu.org id=B36597.15972435964284 (code B ref 36597); Wed, 12 Aug 2020 14:47:02 +0000 Original-Received: (at 36597) by debbugs.gnu.org; 12 Aug 2020 14:46:36 +0000 Original-Received: from localhost ([127.0.0.1]:45143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5s1U-000172-EX for submit@debbugs.gnu.org; Wed, 12 Aug 2020 10:46:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5s1R-00016o-Om for 36597@debbugs.gnu.org; Wed, 12 Aug 2020 10:46:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35227) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5s1L-0006G5-Kf; Wed, 12 Aug 2020 10:46:27 -0400 Original-Received: from [176.228.60.248] (port=2277 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k5s1L-0000oY-4N; Wed, 12 Aug 2020 10:46:27 -0400 In-Reply-To: <83pn7wneed.fsf@gnu.org> (message from Eli Zaretskii on Wed, 12 Aug 2020 17:10:34 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184815 Archived-At: > Date: Wed, 12 Aug 2020 17:10:34 +0300 > From: Eli Zaretskii > Cc: larsi@gnus.org, 36597@debbugs.gnu.org, pipcet@gmail.com > > > Does the attached simplification pacify GCC on MinGW? If so, that could be > > combined with reverting the inttypes change. > > The warnings disappeared because you installed a change that no > longer uses the GCC warning options which triggered them. So I'm > unsure how you'd like me to test the patch, please elaborate. Sorry, I wasn't paying attention: the warnings did not disappear. I've now tried the proposed changes, but they don't affect the code which is cited in the warning messages. The offending code is here: dump_trace (("dump_queue_dequeue basis=%"PRIdDUMP_OFF" fancy=%"PRIdPTR " zero=%"PRIdPTR" normal=%"PRIdPTR" strong=%"PRIdPTR" hash=%td\n"), basis, dump_tailq_length (&dump_queue->fancy_weight_objects), dump_tailq_length (&dump_queue->zero_weight_objects), dump_tailq_length (&dump_queue->one_weight_normal_objects), dump_tailq_length (&dump_queue->one_weight_strong_objects), XHASH_TABLE (dump_queue->link_weights)->count); And it triggers warnings because intptr_t is redefined to be 'long int', whereas PRIdPTR is "d". Here are the warnings again: pdumper.c: In function 'dump_queue_dequeue': pdumper.c:1214:6: warning: format '%d' expects argument of type 'int', but argument 3 has type 'gl_intptr_t' {aka 'long int'} [-Wformat=] 1214 | (("dump_queue_dequeue basis=%"PRIdDUMP_OFF" fancy=%"PRIdPTR | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1215 | " zero=%"PRIdPTR" normal=%"PRIdPTR" strong=%"PRIdPTR" hash=%td\n"), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1216 | basis, 1217 | dump_tailq_length (&dump_queue->fancy_weight_objects), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | gl_intptr_t {aka long int} pdumper.c:1214:6: warning: format '%d' expects argument of type 'int', but argument 4 has type 'gl_intptr_t' {aka 'long int'} [-Wformat=] pdumper.c:1214:6: warning: format '%d' expects argument of type 'int', but argument 5 has type 'gl_intptr_t' {aka 'long int'} [-Wformat=] pdumper.c:1214:6: warning: format '%d' expects argument of type 'int', but argument 6 has type 'gl_intptr_t' {aka 'long int'} [-Wformat=]