From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group Date: Sun, 30 Aug 2020 16:50:04 +0300 Message-ID: <83ft84xmyb.fsf@gnu.org> References: <837dtiymay.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22448"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41145@debbugs.gnu.org, p.stephani2@gmail.com, maurooaranda@gmail.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 30 15:51:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kCNji-0005kT-1B for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Aug 2020 15:51:10 +0200 Original-Received: from localhost ([::1]:33428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCNjg-0006Ex-Ja for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Aug 2020 09:51:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCNja-0006El-Mo for bug-gnu-emacs@gnu.org; Sun, 30 Aug 2020 09:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38122) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kCNja-0003Zj-EE for bug-gnu-emacs@gnu.org; Sun, 30 Aug 2020 09:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kCNja-0000zm-Dg for bug-gnu-emacs@gnu.org; Sun, 30 Aug 2020 09:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Aug 2020 13:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41145 X-GNU-PR-Package: emacs Original-Received: via spool by 41145-submit@debbugs.gnu.org id=B41145.15987954173769 (code B ref 41145); Sun, 30 Aug 2020 13:51:02 +0000 Original-Received: (at 41145) by debbugs.gnu.org; 30 Aug 2020 13:50:17 +0000 Original-Received: from localhost ([127.0.0.1]:49668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCNir-0000yj-8i for submit@debbugs.gnu.org; Sun, 30 Aug 2020 09:50:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCNip-0000yV-LB for 41145@debbugs.gnu.org; Sun, 30 Aug 2020 09:50:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39999) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCNik-0003Mb-AJ; Sun, 30 Aug 2020 09:50:10 -0400 Original-Received: from [176.228.60.248] (port=4489 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kCNij-0003MG-I8; Sun, 30 Aug 2020 09:50:10 -0400 In-Reply-To: (message from Stefan Monnier on Sat, 29 Aug 2020 23:58:04 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186691 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii , Philipp Stephani , > 41145@debbugs.gnu.org > Date: Sat, 29 Aug 2020 23:58:04 -0400 > > >>>> Or if eventually a defface or a defcustom makes its way into > >>>> display-fill-column-indicator.el, of course. > >> > >> Actually, there is a defcustom there (in the expansion of > >> `define-globalized-minor-mode`). > > > > Sorry, I wasn't clear enough. There is no defcustom or defface whose > > :group is display-fill-column-indicator. > > `global-display-fill-column-indicator-mode` should definitely belong to > the `display-fill-column-indicator` group (because the `defcustom` > doesn't have an explicit `:group` so it should fallback to using the > last-defined group). So you are saying this should have worked as it is? > BTW, another quick-fix might be to move the defface definition to > display-fill-column-indicator.el. The idea was not to require display-fill-column-indicator.el be loaded to activate the feature.