From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#43756: Fix for TTY menus mouse interaction Date: Sat, 03 Oct 2020 10:23:09 +0300 Message-ID: <83ft6vepsy.fsf@gnu.org> References: <41afb058e440b1b8e681ce38e1f7b014@finder.org> <871rigwv65.fsf@gnus.org> <3d6b6e0f894ab59c3b0df9394182f498@finder.org> <83k0w8e7z8.fsf@gnu.org> <094def0cf664c29c513b0686929eb808@finder.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39011"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43756@debbugs.gnu.org, larsi@gnus.org To: Jared Finder Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 03 09:24:24 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kObu3-000A3H-St for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Oct 2020 09:24:23 +0200 Original-Received: from localhost ([::1]:59620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kObu2-0003ia-Uf for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Oct 2020 03:24:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44990) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kObti-0003iM-Lq for bug-gnu-emacs@gnu.org; Sat, 03 Oct 2020 03:24:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59585) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kObti-0002MT-CY for bug-gnu-emacs@gnu.org; Sat, 03 Oct 2020 03:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kObti-0008Di-7Y for bug-gnu-emacs@gnu.org; Sat, 03 Oct 2020 03:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Oct 2020 07:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43756 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43756-submit@debbugs.gnu.org id=B43756.160170980431551 (code B ref 43756); Sat, 03 Oct 2020 07:24:02 +0000 Original-Received: (at 43756) by debbugs.gnu.org; 3 Oct 2020 07:23:24 +0000 Original-Received: from localhost ([127.0.0.1]:42898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kObt5-0008Cp-My for submit@debbugs.gnu.org; Sat, 03 Oct 2020 03:23:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kObt2-0008CX-It for 43756@debbugs.gnu.org; Sat, 03 Oct 2020 03:23:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50954) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kObsv-0002JQ-Nk; Sat, 03 Oct 2020 03:23:14 -0400 Original-Received: from [176.228.60.248] (port=1195 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kObst-0003qF-JI; Sat, 03 Oct 2020 03:23:13 -0400 In-Reply-To: <094def0cf664c29c513b0686929eb808@finder.org> (message from Jared Finder on Fri, 02 Oct 2020 12:54:54 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189686 Archived-At: > Date: Fri, 02 Oct 2020 12:54:54 -0700 > From: Jared Finder > Cc: larsi@gnus.org, 43756@debbugs.gnu.org > > > Ah, xterm-mouse-mode. AFAIR, no one has made TTY menus work with > > xterm-mouse-mode. The first thing to do is to disable tmm-menubar, > > and then you need to cause a mouse click call menu-bar-open with the > > 2nd argument set to the X coordinate of the click. > > I think this may be getting mixed up with my feature proposal on > emacs-devel? I did find this bug when working on making the TTY menus > work with xterm-mouse-mode and they both affect menus. The patches I > attached in that thread follow the pattern you described. > > This bug report is separable from the rest of that feature. It's also > much smaller, just two lines. :) This fixes the current behavior of the > command tmm-menubar-mouse, which is bound to . So you are saying that when tmm-menubar-mouse is invoked by mouse clicks, it shows incorrect menus after "M-x ielm", but only if you click on the menu items specific to IELM? It sounds like tmm-menubar has a bug in its translation of the X coordinate of the click to the menu-bar item, perhaps because it considers only the global menu keymap.