From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#46827: Broken initial size of GTK3 frame Date: Sat, 06 Mar 2021 13:15:29 +0200 Message-ID: <83ft18wn1q.fsf@gnu.org> References: <6caa020a-084c-e3f2-7a34-262f7127b21b@gmx.at> <87eegz41ui.fsf@gmail.com> <875z2b3srx.fsf@gmail.com> <87ft1fyo88.fsf@gmail.com> <8a346498-e7e3-ca92-e518-86f6fc2c37b7@gmx.at> <87y2f6spgm.fsf@gmail.com> <87v9aaslh9.fsf@gmx.net> <689ba08c-639f-af40-5c30-95dcceac552f@gmx.at> <359cec57-48d3-dc97-df0f-a778a0786001@gmx.at> <83zgzl63y0.fsf@gnu.org> <83tupt5x95.fsf@gnu.org> <83a5e0e7-a55d-48bf-00f6-942d6c6c3be5@gmx.at> <83eegw61zc.fsf@gnu.org> <735366e4-389c-1c71-438d-6d928de02e44@gmx.at> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15431"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46827@debbugs.gnu.org, rpluim@gmail.com, stephen.berman@gmx.net To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 06 12:16:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lIUuo-0003t7-3i for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Mar 2021 12:16:10 +0100 Original-Received: from localhost ([::1]:35026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIUum-0004Cr-QS for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Mar 2021 06:16:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIUug-0004Ck-Bg for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 06:16:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52828) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lIUug-0004SI-4D for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 06:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lIUuf-0001Wn-Vk for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 06:16:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Mar 2021 11:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46827 X-GNU-PR-Package: emacs Original-Received: via spool by 46827-submit@debbugs.gnu.org id=B46827.16150293515856 (code B ref 46827); Sat, 06 Mar 2021 11:16:01 +0000 Original-Received: (at 46827) by debbugs.gnu.org; 6 Mar 2021 11:15:51 +0000 Original-Received: from localhost ([127.0.0.1]:36141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIUuV-0001WO-Ab for submit@debbugs.gnu.org; Sat, 06 Mar 2021 06:15:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIUuT-0001WB-GF for 46827@debbugs.gnu.org; Sat, 06 Mar 2021 06:15:50 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37236) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIUuN-0004Hv-V1; Sat, 06 Mar 2021 06:15:43 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4017 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lIUuN-0002Bk-Dk; Sat, 06 Mar 2021 06:15:43 -0500 In-Reply-To: <735366e4-389c-1c71-438d-6d928de02e44@gmx.at> (message from martin rudalics on Wed, 3 Mar 2021 10:40:04 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201609 Archived-At: > Cc: stephen.berman@gmx.net, rpluim@gmail.com, 46827@debbugs.gnu.org > From: martin rudalics > Date: Wed, 3 Mar 2021 10:40:04 +0100 > > >> if (!must_finish) > >> { > >> do_pending_window_change (true); > >> /* If selected_window changed, redisplay again. */ > >> if (WINDOWP (selected_window) > >> && (w = XWINDOW (selected_window)) != sw) > >> goto retry; > >> > >> not check for windows_or_buffers_changed too just as we do after the > >> third do_pending_window_change call? > > > > Because going to 'retry' will eventually make that check again. Or > > maybe I don't understand what exactly are you asking here? > > The check above doesn't care about windows_or_buffers_changed. The last > one in redisplay_internal does: > > /* Change frame size now if a change is pending. */ > do_pending_window_change (true); > > /* If we just did a pending size change, or have additional > visible frames, or selected_window changed, redisplay again. */ > if ((windows_or_buffers_changed && !pending) > || (WINDOWP (selected_window) > && (w = XWINDOW (selected_window)) != sw)) > goto retry; > > So if in the (!must_finish) guarded check windows_or_buffers_changed was > set but the selected window remained unchanged, we don't go to retry. I still don't see the problem, because that last check you show above will catch that, right? > >> But then I don't understand why we > >> check for windows_or_buffers_changed at all. adjust_frame_size doesn't > >> set that IIUC but it does garbage the frame - why don't we check that in > >> redisplay_internal? > > > > Sorry, I don't understand the question. We _are_ talking about > > redisplay_internal, right? and redisplay_internal does check > > windows_or_buffers_changed, right? so what do you mean by "why don't > > we check that in redisplay_internal"? and what is "that" in this case? > > I meant to ask why we don't check the f->garbaged flag of the frame > instead of windows_or_buffers_changed. do_pending_window_change to my > knowledge does not set windows_or_buffers_changed but sets the garbaged > flag. SET_FRAME_GARBAGED also causes windows_or_buffers_changed to be set.