From: Eli Zaretskii <eliz@gnu.org>
To: Ioannis Kappas <ioannis.kappas@gmail.com>
Cc: 47581@debbugs.gnu.org
Subject: bug#47581: 27.1; tab-bar missed mouse clicks on MS-Windows
Date: Sun, 11 Apr 2021 12:24:09 +0300 [thread overview]
Message-ID: <83fszx41ja.fsf@gnu.org> (raw)
In-Reply-To: <CAMRHuGDyM+5V46=CeqCQmhU1TrNSbCerJ531zvPKiQ-Z=NN_fQ@mail.gmail.com> (message from Ioannis Kappas on Sun, 4 Apr 2021 20:43:44 +0100)
> From: Ioannis Kappas <ioannis.kappas@gmail.com>
> Date: Sun, 4 Apr 2021 20:49:24 +0100
> Cc: juri@linkov.net, 47581@debbugs.gnu.org
>
> I think the actual problem is elsewhere: in handle_tab_bar_click. It
> includes code that was copied from handle_tool_bar_click, and which
> pays attention to the value of mouse-highlight. But tab-bar buttons
> don't behave like tool-bar buttons in this regard: they don't respond
> to moving the mouse pointer to them by "activating" the button. So I
> think that code should be removed from handle_tab_bar_click. To wit:
> turn mouse-highlight off (M-x set-variable RET mouse-highlight RET nil
> RET), and clicks on tab-bar buttons miraculously start working with
> 100% reliability.
>
> This will indeed also solve the problem by removing the comparison in
> B.1.1 which is using the potentially stale
> src/frame.h:MOUSE_HL_INFO, which to me seems to be the source of the
> problem. And it is an even better solution, since that part of the
> code might have been included there only by mistake. Nice catch!
This should now be fixed on the master branch.
> Regardless of this though, assuming the above sketch is correct,
> shouldn't we also consider fixing the code in
> src/xdisp.c:remember_mouse_glyph so as to set the
> src/w32term.h:FRAME_DISPLAY_INFO's `last_mouse_glyph' using
> `text-glyph' coordinates, so as for A.1.1 to fire up based on the actual tab-bar
> glyph coordinates during a mouse move (so that MOUSE_HL_INFO does not
> contain stale information)? I can't think of a reason why we might want this to
> be set using virtual-glyph coords when over the tab-bar (but then, I can only see some of
> the pieces and not the whole picture as you do).
If you can show some scenario where this causes real problems, I will
look into it. In my testing, I saw no problems, and the coordinates I
saw weren't wrong, in the sense that they missed some glyphs due to
problems with glyph dimensions.
next prev parent reply other threads:[~2021-04-11 9:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-03 11:20 bug#47581: 27.1; tab-bar missed mouse clicks on MS-Windows Ioannis Kappas
2021-04-03 11:26 ` Ioannis Kappas
2021-04-03 13:56 ` Eli Zaretskii
[not found] ` <CAMRHuGDyM+5V46=CeqCQmhU1TrNSbCerJ531zvPKiQ-Z=NN_fQ@mail.gmail.com>
2021-04-04 19:49 ` bug#47581: Fwd: " Ioannis Kappas
2021-04-11 9:24 ` Eli Zaretskii [this message]
2021-04-04 23:00 ` Juri Linkov
2021-04-11 9:21 ` Eli Zaretskii
2021-04-11 21:53 ` Juri Linkov
2021-04-12 2:31 ` Eli Zaretskii
2021-04-12 16:07 ` Juri Linkov
2021-04-13 13:44 ` Eli Zaretskii
2021-04-13 16:14 ` Juri Linkov
2021-04-13 16:33 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fszx41ja.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=47581@debbugs.gnu.org \
--cc=ioannis.kappas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).