From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#47832: 28.0.50; define-fringe-bitmap and emacs --daemon Date: Sat, 17 Apr 2021 14:21:06 +0300 Message-ID: <83fszpw40t.fsf@gnu.org> References: <7dee3f4235cf450a3254@heytings.org> <83mttxwgm8.fsf@gnu.org> <1869622e16688e6aedec@heytings.org> <83h7k5w54l.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7576"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47832@debbugs.gnu.org To: gregory@heytings.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 17 13:22:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lXj1f-0001pO-8n for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Apr 2021 13:22:11 +0200 Original-Received: from localhost ([::1]:35562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXj1e-00072a-CK for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Apr 2021 07:22:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38496) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXj1W-00072G-9p for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 07:22:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59051) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lXj1W-00072a-2U for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 07:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lXj1V-0002r0-U7 for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 07:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Apr 2021 11:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47832 X-GNU-PR-Package: emacs Original-Received: via spool by 47832-submit@debbugs.gnu.org id=B47832.161865848310920 (code B ref 47832); Sat, 17 Apr 2021 11:22:01 +0000 Original-Received: (at 47832) by debbugs.gnu.org; 17 Apr 2021 11:21:23 +0000 Original-Received: from localhost ([127.0.0.1]:42364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXj0s-0002q4-Sl for submit@debbugs.gnu.org; Sat, 17 Apr 2021 07:21:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXj0r-0002pr-Cp for 47832@debbugs.gnu.org; Sat, 17 Apr 2021 07:21:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60238) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXj0k-0006dy-Jm; Sat, 17 Apr 2021 07:21:15 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4704 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lXj0j-00086o-B8; Sat, 17 Apr 2021 07:21:14 -0400 In-Reply-To: <83h7k5w54l.fsf@gnu.org> (message from Eli Zaretskii on Sat, 17 Apr 2021 13:57:14 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204185 Archived-At: > Date: Sat, 17 Apr 2021 13:57:14 +0300 > From: Eli Zaretskii > Cc: 47832@debbugs.gnu.org > > > Got it! :-) The commit I identified is indeed the culprit. With > > USE_CAIRO, gui_init_fringe() is called in x_initialize(); without > > USE_CAIRO it isn't. And gui_init_fringe() had a bug, which should now be > > fixed on Windows, too. Patch attached. > > Thanks, but is this really all that needs to be done? How will > gui_init_fringe be called in the non-Cairo builds? And what about NS? Answering myself: they don't need to call gui_init_fringe. Since gui_init_fringe returns immediately if the frame interface doesn't provide a method for fringe initialization, I think we should call gui_init_fringe unconditionally on X. And in any case, the patch for gui_init_fringe is sub-optimal: it unnecessarily loops over the standard bitmaps that were superseded. It is better to leave the first loop go over the standard bitmaps, whether superseded or not, and the second loop go over non-standard bitmaps only. Thanks.