unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: larsi@gnus.org, 48298@debbugs.gnu.org, lewwadoo@gmail.com
Subject: bug#48298: Invalid time specification: encode-time((0 30 11 1 1 0 nil -1 nil))
Date: Sun, 09 May 2021 11:27:32 +0300	[thread overview]
Message-ID: <83fsyw8g7f.fsf@gnu.org> (raw)
In-Reply-To: <87fsyw5nfg.fsf@tcd.ie> (contovob@tcd.ie)

> From: "Basil L. Contovounesios" <contovob@tcd.ie>
> Cc: Евгений Михайлов
>  <lewwadoo@gmail.com>,  48298@debbugs.gnu.org
> Date: Sun, 09 May 2021 09:19:47 +0100
> 
> > I guess the problem is in decoded-time-set-defaults, if anywhere.
> 
> Lars?

As the minimum fix, perhaps instead of using zero as the missing year
we should use 1970, as zero could not be representable on some
systems.

> BTW I just noticed that decoded-time-set-defaults was mistakenly
> announced in NEWS as encoded-time-set-defaults - should that be fixed on
> emacs-27 or master?

Master, I guess.

> > However, I'm not sure I understand the idea behind your
> > my-mins-between: how did you expect Emacs to guess the year you had in
> > mind?
> 
> The year doesn't matter, since my-mins-between cares only about the
> relative difference between strings of the form "HH:mm", i.e. the hours
> and minutes fields.

Yes, it does matter: see the comment by Andreas.





  reply	other threads:[~2021-05-09  8:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-08 16:55 bug#48298: Invalid time specification: encode-time((0 30 11 1 1 0 nil -1 nil)) Евгений Михайлов
2021-05-08 22:37 ` Basil L. Contovounesios
2021-05-09  7:07   ` Eli Zaretskii
2021-05-09  6:46 ` Eli Zaretskii
2021-05-09  8:19   ` Basil L. Contovounesios
2021-05-09  8:27     ` Eli Zaretskii [this message]
2021-05-09  8:54       ` Basil L. Contovounesios
2021-05-09  9:52         ` Lars Ingebrigtsen
2021-05-09 10:03           ` Basil L. Contovounesios
2021-05-09 10:09             ` Lars Ingebrigtsen
2021-05-09 11:02               ` Basil L. Contovounesios
2021-05-09 10:35         ` Eli Zaretskii
2021-05-09 10:59           ` Basil L. Contovounesios
2021-05-09 11:49             ` Eli Zaretskii
2021-05-09 13:57               ` Basil L. Contovounesios
2021-05-09  7:30 ` Andreas Schwab
2021-05-11 20:56 ` bug#48298: Евгений Михайлов
2021-05-11 21:37   ` bug#48298: Basil L. Contovounesios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fsyw8g7f.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=48298@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=larsi@gnus.org \
    --cc=lewwadoo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).