From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35264: "Match data clobbered by buffer modification hooks" when hooks only shifted match-data's markers Date: Wed, 12 May 2021 19:03:04 +0300 Message-ID: <83fsys2b47.fsf@gnu.org> References: <87h8b119oy.fsf@gmail.com> <871s0f7det.fsf@gmail.com> <87a6x5z11g.fsf@gnus.org> <8735usj9z9.fsf@gnus.org> <83o8dg2e81.fsf@gnu.org> <87cztwhs9m.fsf@gnus.org> <83im3o2brt.fsf@gnu.org> <87v97ogd2d.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33624"; mail-complaints-to="usenet@ciao.gmane.io" Cc: npostavs@gmail.com, monnier@iro.umontreal.ca, 35264@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 12 18:08:02 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgrOZ-0007lZ-5C for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 May 2021 18:07:35 +0200 Original-Received: from localhost ([::1]:47738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgrOY-0006G2-5Q for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 May 2021 12:07:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57884) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgrL8-0007Ww-Ls for bug-gnu-emacs@gnu.org; Wed, 12 May 2021 12:04:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56835) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lgrL8-0002i9-Dm for bug-gnu-emacs@gnu.org; Wed, 12 May 2021 12:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lgrL8-0006Qw-9H for bug-gnu-emacs@gnu.org; Wed, 12 May 2021 12:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 May 2021 16:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35264 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35264-submit@debbugs.gnu.org id=B35264.162083538524645 (code B ref 35264); Wed, 12 May 2021 16:04:02 +0000 Original-Received: (at 35264) by debbugs.gnu.org; 12 May 2021 16:03:05 +0000 Original-Received: from localhost ([127.0.0.1]:40148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgrKD-0006PR-6e for submit@debbugs.gnu.org; Wed, 12 May 2021 12:03:05 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgrKA-0006Oc-LX for 35264@debbugs.gnu.org; Wed, 12 May 2021 12:03:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34804) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgrK5-00027p-2o; Wed, 12 May 2021 12:02:57 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2190 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgrK4-0008Cj-D2; Wed, 12 May 2021 12:02:56 -0400 In-Reply-To: <87v97ogd2d.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed, 12 May 2021 17:57:14 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206346 Archived-At: > From: Lars Ingebrigtsen > Cc: npostavs@gmail.com, monnier@iro.umontreal.ca, 35264@debbugs.gnu.org > Date: Wed, 12 May 2021 17:57:14 +0200 > > Eli Zaretskii writes: > > >> I tried the code example in that bug report now (with the patch that > >> removes the sanity check), and it did not crash Emacs. So that sanity > >> check no longer seems to be necessary? > > > > Probably because some code somewhere uses save-match-data. > > I guess. But we have a case here where the sanity check is definitely > wrong, and we don't have a reproducing case (any more) for the problem > the check is trying to fix... which seems to indicate to me that we > should apply the patch (i.e., remove the buggy sanity check). I'm not against applying the change, I just wonder why Stefan wasn't against it back then as he is now.