From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48408: BUGFIX: window-default-font-height: check for nil string Date: Sun, 16 May 2021 12:36:08 +0300 Message-ID: <83fsynuik7.fsf@gnu.org> References: <20210514011519.vsy5jbhyxd4v6kpt@E15-2016.optimum.net> <83mtsxzund.fsf@gnu.org> <20210516030618.7caj6icukblavhbp@E15-2016.optimum.net> <835yzjwbnj.fsf@gnu.org> <20210516044215.23yd5ae3yeby6kaq@E15-2016.optimum.net> <83zgwvuu5z.fsf@gnu.org> <83tun3ur7h.fsf@gnu.org> <20210516065904.5wweuipi23oy5g2x@E15-2016.optimum.net> <83pmxrulm4.fsf@gnu.org> <83lf8fukdu.fsf@gnu.org> <83im3jujtg.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14104"; mail-complaints-to="usenet@ciao.gmane.io" Cc: boruch_baum@gmx.com, 48408@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 16 11:38:34 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1liDEI-0003Ul-ER for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 May 2021 11:38:34 +0200 Original-Received: from localhost ([::1]:56456 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liDEH-0001YL-HM for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 May 2021 05:38:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40240) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liDCn-0000At-VX for bug-gnu-emacs@gnu.org; Sun, 16 May 2021 05:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38182) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1liDCn-0000kz-Np for bug-gnu-emacs@gnu.org; Sun, 16 May 2021 05:37:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1liDCn-0003Kg-JE for bug-gnu-emacs@gnu.org; Sun, 16 May 2021 05:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 May 2021 09:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48408 X-GNU-PR-Package: emacs Original-Received: via spool by 48408-submit@debbugs.gnu.org id=B48408.162115777612755 (code B ref 48408); Sun, 16 May 2021 09:37:01 +0000 Original-Received: (at 48408) by debbugs.gnu.org; 16 May 2021 09:36:16 +0000 Original-Received: from localhost ([127.0.0.1]:49728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liDC4-0003Je-HY for submit@debbugs.gnu.org; Sun, 16 May 2021 05:36:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liDC3-0003JS-NB for 48408@debbugs.gnu.org; Sun, 16 May 2021 05:36:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45750) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liDBy-0000Ab-0V; Sun, 16 May 2021 05:36:10 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2934 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liDBx-0006nr-B8; Sun, 16 May 2021 05:36:09 -0400 In-Reply-To: (message from martin rudalics on Sun, 16 May 2021 11:28:00 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206652 Archived-At: > Cc: boruch_baum@gmx.com, 48408@debbugs.gnu.org > From: martin rudalics > Date: Sun, 16 May 2021 11:28:00 +0200 > > > Actually, no, I do have an opinion on that: face-font can return a > > string even on a TTY frame, at least in a build --without-x. (Which > > seems to be an inconsistency in and of itself, btw.) > > > > In general, trusting frame parameters too much is IME not a good idea, > > as they are too loosely defined. > > Is it possible that `window-font-width' and `window-font-height' run > into a similar problem when `face-font' returns nil? I don't think so, because they call display-multi-font-p without arguments.