From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50195: [PATCH] Adding diary-offset, a diary-sexp offsetting another diary-sexp. Date: Wed, 25 Aug 2021 15:24:54 +0300 Message-ID: <83fsuxvhih.fsf@gnu.org> References: <87fsuychjr.fsf@ypei.me> <83mtp5vizs.fsf@gnu.org> <875yvtk9ud.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1603"; mail-complaints-to="usenet@ciao.gmane.io" Cc: hi@ypei.me, 50195@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 25 14:26:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mIryv-0000BN-HI for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Aug 2021 14:26:13 +0200 Original-Received: from localhost ([::1]:36410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mIryu-00023n-BH for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Aug 2021 08:26:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42992) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIryl-00020t-M3 for bug-gnu-emacs@gnu.org; Wed, 25 Aug 2021 08:26:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34472) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mIryl-0005Cw-FF for bug-gnu-emacs@gnu.org; Wed, 25 Aug 2021 08:26:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mIryk-0008GU-CC for bug-gnu-emacs@gnu.org; Wed, 25 Aug 2021 08:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Aug 2021 12:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50195 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50195-submit@debbugs.gnu.org id=B50195.162989431231690 (code B ref 50195); Wed, 25 Aug 2021 12:26:02 +0000 Original-Received: (at 50195) by debbugs.gnu.org; 25 Aug 2021 12:25:12 +0000 Original-Received: from localhost ([127.0.0.1]:46014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIrxs-0008Ev-HM for submit@debbugs.gnu.org; Wed, 25 Aug 2021 08:25:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIrxm-0008ED-9d for 50195@debbugs.gnu.org; Wed, 25 Aug 2021 08:25:06 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44994) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mIrxg-0004nO-UT; Wed, 25 Aug 2021 08:24:56 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4927 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIrxg-0002Kx-Hi; Wed, 25 Aug 2021 08:24:56 -0400 In-Reply-To: <875yvtk9ud.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed, 25 Aug 2021 14:06:02 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212620 Archived-At: > From: Lars Ingebrigtsen > Cc: Yuchen Pei , 50195@debbugs.gnu.org > Date: Wed, 25 Aug 2021 14:06:02 +0200 > > Eli Zaretskii writes: > > >> + (with-no-warnings (defvar date) (defvar entry)) > > > > Why did you need this? > > It's how all these functions in diary-lib are defined after the lexical > rewrite -- the `eval' depends on those dynamic variables. Ugh! Is it worth it? If we cannot convert these functions to use lexical-binding, maybe we should say lexical-binding: nil in the first line of the file, and remove all those gross kludges?