From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51037: [PATCH] Make `print-level` & `print-length` customizable in ERT batch tests Date: Wed, 06 Oct 2021 15:52:13 +0300 Message-ID: <83fste2u4i.fsf@gnu.org> References: <86tuhvmtpl.fsf@runbox.com> <877deqec10.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32875"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sp1ff@runbox.com, 51037@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 06 14:53:28 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mY6QJ-0008LX-Qj for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Oct 2021 14:53:27 +0200 Original-Received: from localhost ([::1]:40058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mY6QI-0008D5-Qz for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Oct 2021 08:53:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mY6Pu-0007kr-FH for bug-gnu-emacs@gnu.org; Wed, 06 Oct 2021 08:53:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59615) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mY6Pu-00072V-6S for bug-gnu-emacs@gnu.org; Wed, 06 Oct 2021 08:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mY6Pu-0006ws-5c for bug-gnu-emacs@gnu.org; Wed, 06 Oct 2021 08:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Oct 2021 12:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51037-submit@debbugs.gnu.org id=B51037.163352474826667 (code B ref 51037); Wed, 06 Oct 2021 12:53:02 +0000 Original-Received: (at 51037) by debbugs.gnu.org; 6 Oct 2021 12:52:28 +0000 Original-Received: from localhost ([127.0.0.1]:42928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mY6PL-0006w3-Nz for submit@debbugs.gnu.org; Wed, 06 Oct 2021 08:52:27 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mY6PK-0006vq-A4 for 51037@debbugs.gnu.org; Wed, 06 Oct 2021 08:52:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48988) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mY6PE-0006jh-Aa; Wed, 06 Oct 2021 08:52:20 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3224 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mY6PD-0003t4-Tn; Wed, 06 Oct 2021 08:52:20 -0400 In-Reply-To: <877deqec10.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed, 06 Oct 2021 11:30:03 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216554 Archived-At: > From: Lars Ingebrigtsen > Date: Wed, 06 Oct 2021 11:30:03 +0200 > Cc: 51037@debbugs.gnu.org > > Michael writes: > > > When running ERT tests in batch mode, the conservative values > > chosen for `print-level` and `print-length` sometimes make it > > difficult to see what exactly is wrong. This patch introduces > > two new variables (`ert-batch-print-level` & > > `ert-batch-print-length`) that one can use to customize them; > > e.g. > > > > emacs -batch -l ert -l my-tests.el \ > > --eval "(let ((ert-batch-print-level 10) \ > > (ert-batch-print-length 120)) \ > > (ert-run-tests-batch-and-exit))" > > Sounds like a good idea. Why do we limit print-length in batch mode? In interactive session, one can click or type RET on the ellipsis and get it expanded, but no such joy in batch. See https://lists.gnu.org/archive/html/emacs-devel/2021-10/msg00395.html for how that makes debugging more difficult than it has to be. So how about using huge values in batch? Are there any downsides?