From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#49797: 28.0.50; Setting face to custom fontset doesn't work Date: Fri, 08 Oct 2021 08:38:07 +0300 Message-ID: <83fstcyt34.fsf@gnu.org> References: <87y29k2h4z.fsf@gnu.org> <3B853424-9F63-4A6B-B7A9-2E3AB71986AC@gmail.com> <835yub4fj5.fsf@gnu.org> <8FD18262-3F40-4033-A49D-F6CEA89A3A31@gmail.com> <83sfxf2ry5.fsf@gnu.org> <1AF30098-F55E-48A7-A0D4-E529DFBA6895@gmail.com> <838rz62kx8.fsf@gnu.org> <890ABB11-65A7-4F52-8816-7FA90BED7961@gmail.com> <83zgrm0zqt.fsf@gnu.org> <219B3DA8-2E40-4BC1-8235-7330308F1737@gmail.com> <83y2760yec.fsf@gnu.org> <8B79C354-D63D-42F4-9910-72B3568315CD@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12230"; mail-complaints-to="usenet@ciao.gmane.io" Cc: handa@gnu.org, 49797@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 08 07:40:08 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYic4-00030i-LJ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Oct 2021 07:40:08 +0200 Original-Received: from localhost ([::1]:54828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYic2-00073C-1c for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Oct 2021 01:40:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYib2-000730-Eq for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 01:39:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37354) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mYib0-0002v9-3o for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 01:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mYiaz-0004Ad-Sf for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 01:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Oct 2021 05:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49797 X-GNU-PR-Package: emacs Original-Received: via spool by 49797-submit@debbugs.gnu.org id=B49797.163367152116003 (code B ref 49797); Fri, 08 Oct 2021 05:39:01 +0000 Original-Received: (at 49797) by debbugs.gnu.org; 8 Oct 2021 05:38:41 +0000 Original-Received: from localhost ([127.0.0.1]:48900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYiae-0004A3-PC for submit@debbugs.gnu.org; Fri, 08 Oct 2021 01:38:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYiaZ-00049o-8l for 49797@debbugs.gnu.org; Fri, 08 Oct 2021 01:38:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58078) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYiaT-0002P8-RD; Fri, 08 Oct 2021 01:38:29 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2274 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYiaQ-00023V-J4; Fri, 08 Oct 2021 01:38:29 -0400 In-Reply-To: <8B79C354-D63D-42F4-9910-72B3568315CD@gmail.com> (message from Yuan Fu on Thu, 7 Oct 2021 13:13:28 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216694 Archived-At: > From: Yuan Fu > Date: Thu, 7 Oct 2021 13:13:28 -0700 > Cc: Kenichi Handa , > 49797@debbugs.gnu.org > > >> if (face->ascii_face->font) > >> { > >> XSETFONT (font_object, face->ascii_face->font); > >> if (font_has_char (f, font_object, c)) > >> return face->ascii_face->id; > >> } > > > > No, this is where we try to use the ASCII font for symbols and > > punctuation characters. > > You are right. > > > > >> And what about the comment I mentioned? Did you read it? > > > > Yes, but it has no relevance to the issue at hand. That whole part is > > about displaying symbol and punctuation characters. > > It IMO reveals the writer’s intent that fontset can be used to force a face to display certain characters with certain font. I don't see how you arrived at that conclusion. What the above snippet does is simply check whether the face's font used for the ASCII characters (which is the default font of the face) is capable of displaying the given symbol or punctuation character, and if so, it uses that default font instead of consulting the fontset (where symbol and punctuation characters could be assigned to a different font). There's no reference or usage of any fontset in this code snippet.