From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff buffers Date: Sun, 26 Dec 2021 18:21:42 +0200 Message-ID: <83fsqfnxpl.fsf@gnu.org> References: <87lf1sw6ji.fsf@gmail.com> <86h7cgdk4v.fsf@mail.linkov.net> <87ee7kvshn.fsf@gmail.com> <87a6i7x5iq.fsf@gmail.com> <86k0hbam7r.fsf@mail.linkov.net> <878rxrmy7q.fsf@gmail.com> <86y256uc0v.fsf@mail.linkov.net> <87r1ajknsr.fsf@gmail.com> <86ilvu6w6k.fsf@mail.linkov.net> <871r2hc51a.fsf@gmail.com> <87r19zs662.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40701"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51809@debbugs.gnu.org, juri@linkov.net To: Matthias Meulien Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 26 17:22:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1WHk-000ALp-GY for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Dec 2021 17:22:12 +0100 Original-Received: from localhost ([::1]:59976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n1WHi-00036l-Vm for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Dec 2021 11:22:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34240) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1WHa-00033d-PV for bug-gnu-emacs@gnu.org; Sun, 26 Dec 2021 11:22:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58056) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n1WHa-0005H3-G5 for bug-gnu-emacs@gnu.org; Sun, 26 Dec 2021 11:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n1WHa-0002GW-DI for bug-gnu-emacs@gnu.org; Sun, 26 Dec 2021 11:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Dec 2021 16:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51809 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51809-submit@debbugs.gnu.org id=B51809.16405356978672 (code B ref 51809); Sun, 26 Dec 2021 16:22:02 +0000 Original-Received: (at 51809) by debbugs.gnu.org; 26 Dec 2021 16:21:37 +0000 Original-Received: from localhost ([127.0.0.1]:41369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1WHA-0002Fn-P5 for submit@debbugs.gnu.org; Sun, 26 Dec 2021 11:21:37 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1WH9-0002FY-G0 for 51809@debbugs.gnu.org; Sun, 26 Dec 2021 11:21:35 -0500 Original-Received: from [2001:470:142:3::e] (port=57308 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1WH4-00059e-2Q; Sun, 26 Dec 2021 11:21:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=thFBSIxK+setVGIFc7B0Z/FeCaeaWCYL1SeGO7piPwY=; b=ptN7I9McvFem twpXnwsfqYbV0si7b3r75/6QgJUdbA4rGAquPZ17F7DzffVxzBX9EEUHVPqda/F5y27aa9IIpcuFv 3Kb93RGUqST0WURZtEsESHjgolVc+qMToF+eyDo4nFe9x8qEDspxR7GYbxLIihsCF586Pujt+hlFz X4aRI8wpZyzhL/M6rZSIpneKayU77Sz7UqFMMgxteyecq+rHQhvVLnWanj+cpJXvdauWgVON+i7ae GSmbE8MOKjvnvdbpleFDka5T75UOishaNFryAzHjrkR2cdjobpcmFeCDnTPaTG36T4CVQlgXeTax3 x1Po9iTsgY+H+rZAbvTXoQ==; Original-Received: from [87.69.77.57] (port=2897 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1WH2-0001JK-C4; Sun, 26 Dec 2021 11:21:30 -0500 In-Reply-To: <87r19zs662.fsf@gmail.com> (message from Matthias Meulien on Sun, 26 Dec 2021 17:05:25 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223152 Archived-At: > From: Matthias Meulien > Date: Sun, 26 Dec 2021 17:05:25 +0100 > Cc: 51809@debbugs.gnu.org > > Here is an updated patch implementing a default state for Outline mode > and Outline minor mode: Thanks, a few comments to the documentation parts: > +If equal to a number, show only headings up to the corresponding > +level. "Up to and including" or "up to and excluding"? Also, please make sure you leave 2 spaces between sentences in all the doc strings and comments, per our conventions. > + :type '(choice (const :tag "Disabled" nil) It isn't clear what exactly is "disabled" under this value. The doc string itself is also not clear about what happens when the value is nil: "some headings are outlined" leaves me wondering what that means. > +(defcustom outline-default-state-subtree-visibility nil > + "Defines visibility of subtree starting at level defined by `outline-default-state'. Not "Defines", "Determines". Also, the first line is too long. > +When equal to a list, each element is expected to equal one of: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ "...should be one of the following:" (Using "equal" here is not appropriate in any case, since you don't always describe actual values.) > +- A lambda function or function name which will be evaluated with > + point at the beginningg of the heading and the match data set ^^^^^^^^^^ A typo. And finally, I think this should have a NEWS entry.