unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#53269: Fix customization choices for tab-first-completion
@ 2022-01-14 19:51 Philipp Stephani
  2022-01-15  7:23 ` Eli Zaretskii
  0 siblings, 1 reply; 3+ messages in thread
From: Philipp Stephani @ 2022-01-14 19:51 UTC (permalink / raw)
  To: 53269

[-- Attachment #1: Type: text/plain, Size: 700 bytes --]

Tags: patch

The customization choices for tab-first-completion are double-quoted.
The attached patch fixes this.  Can I install it on the release branch?



In GNU Emacs 28.0.91 (build 4, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.16.0)
 of 2022-01-13
Repository revision: 34ca4ff9a52d38250f70f578fd045490b4eef4f9
Repository branch: emacs-28
Windowing system distributor 'The X.Org Foundation', version 11.0.12013000
System Description: Debian GNU/Linux rodete

Configured using:
 'configure --enable-gcc-warnings=warn-only
 --enable-gtk-deprecation-warnings --without-pop --with-mailutils
 --enable-checking=all --enable-check-lisp-object-type --with-modules
 'CFLAGS=-O0 -ggdb3''


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-indent.el-tab-first-completion-Fix-incorrect-ch.patch --]
[-- Type: text/patch, Size: 1263 bytes --]

From 364656460f7c43bd46289a7188499acd9452440c Mon Sep 17 00:00:00 2001
From: Philipp Stephani <phst@google.com>
Date: Fri, 14 Jan 2022 20:49:35 +0100
Subject: [PATCH] * lisp/indent.el (tab-first-completion): Fix incorrect
 choices.

---
 lisp/indent.el | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/lisp/indent.el b/lisp/indent.el
index f0c11ad0df..48e5b309e4 100644
--- a/lisp/indent.el
+++ b/lisp/indent.el
@@ -77,10 +77,11 @@ tab-first-completion
   :group 'indent
   :type '(choice
           (const :tag "Always complete" nil)
-          (const :tag "Unless at the end of a line" 'eol)
-          (const :tag "Unless looking at a word" 'word)
-          (const :tag "Unless at a word or parenthesis" 'word-or-paren)
-          (const :tag "Unless at a word, parenthesis, or punctuation." 'word-or-paren-or-punct))
+          (const :tag "Unless at the end of a line" eol)
+          (const :tag "Unless looking at a word" word)
+          (const :tag "Unless at a word or parenthesis" word-or-paren)
+          (const :tag "Unless at a word, parenthesis, or punctuation."
+                 word-or-paren-or-punct))
   :version "28.1")
 
 (defvar indent-line-ignored-functions '(indent-relative
-- 
2.34.1.703.g22d0c6ccf7-goog


[-- Attachment #3: Type: text/plain, Size: 715 bytes --]


-- 
Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich.  Falls Sie diese fälschlicherweise erhalten haben
sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie
alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail
an die falsche Person gesendet wurde.

This e-mail is confidential.  If you received this communication by mistake,
please don’t forward it to anyone else, please erase all copies and
attachments, and please let me know that it has gone to the wrong person.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#53269: Fix customization choices for tab-first-completion
  2022-01-14 19:51 bug#53269: Fix customization choices for tab-first-completion Philipp Stephani
@ 2022-01-15  7:23 ` Eli Zaretskii
  2022-01-15 11:08   ` Philipp Stephani
  0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2022-01-15  7:23 UTC (permalink / raw)
  To: Philipp Stephani; +Cc: 53269

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Fri, 14 Jan 2022 20:51:43 +0100
> 
> The customization choices for tab-first-completion are double-quoted.
> The attached patch fixes this.  Can I install it on the release branch?

Yes, thanks.





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#53269: Fix customization choices for tab-first-completion
  2022-01-15  7:23 ` Eli Zaretskii
@ 2022-01-15 11:08   ` Philipp Stephani
  0 siblings, 0 replies; 3+ messages in thread
From: Philipp Stephani @ 2022-01-15 11:08 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 53269-done

Am Sa., 15. Jan. 2022 um 08:23 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
>
> > From: Philipp Stephani <p.stephani2@gmail.com>
> > Date: Fri, 14 Jan 2022 20:51:43 +0100
> >
> > The customization choices for tab-first-completion are double-quoted.
> > The attached patch fixes this.  Can I install it on the release branch?
>
> Yes, thanks.

Done (commit 7f36aca99dc1387cfeb599c9f2bb781036f79cf1).





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-01-15 11:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-14 19:51 bug#53269: Fix customization choices for tab-first-completion Philipp Stephani
2022-01-15  7:23 ` Eli Zaretskii
2022-01-15 11:08   ` Philipp Stephani

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).