From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: luangruo@yahoo.com, 54802@debbugs.gnu.org
Subject: bug#54802: OClosure: Make `interactive-form` a generic function
Date: Tue, 19 Apr 2022 16:00:58 +0300 [thread overview]
Message-ID: <83fsm9ut11.fsf@gnu.org> (raw)
In-Reply-To: <jwvlew1w92j.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Tue, 19 Apr 2022 08:38:47 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: luangruo@yahoo.com, 54802@debbugs.gnu.org
> Date: Tue, 19 Apr 2022 08:38:47 -0400
>
> > I'm sorry, but I think the cleanest fix is too much to pay for a minor
> > feature such as this one.
>
> I don't see much price to pay here.
See below.
> Am I the only here who finds that defining `interactive-form` as
> an ELisp generic function is, in itself, a good idea (not good enough
> to do it without a good reason, but something I put on the side of
> "advantages" rather than "defects" when assessing my patch)?
Maybe you aren't the only one, but I don't share that opinion. And in
this particular case, I don't even consider the reason to be anywhere
near "good enough".
> > Can't you find a less intrusive way of fixing these issues, one that
> > doesn't affect all of Emacs for the benefit of one or two packages of
> > minor importance?
>
> Not sure what you mean by "affect all of Emacs". It affects
> a well-delimited (and small) part of the code.
It is called outside of the advice functions.
> Are you worried about introducing bugs, about the performance impact,
> or something else?
All of them. And again, the reason doesn't seem to justify the risks,
not IMO.
next prev parent reply other threads:[~2022-04-19 13:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 20:33 bug#54802: OClosure: Make `interactive-form` a generic function Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-09 5:58 ` Eli Zaretskii
2022-04-09 13:50 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-10 12:45 ` Lars Ingebrigtsen
2022-04-13 7:53 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-14 18:34 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-15 0:46 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-15 1:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-15 1:37 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-15 3:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-15 4:27 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-15 16:08 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-15 16:14 ` Eli Zaretskii
2022-04-18 22:59 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-19 5:40 ` Eli Zaretskii
2022-04-19 12:38 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-19 12:43 ` Lars Ingebrigtsen
2022-04-19 13:00 ` Eli Zaretskii [this message]
2022-04-19 13:34 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-19 13:53 ` Eli Zaretskii
2022-04-19 14:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-19 16:35 ` Eli Zaretskii
2022-04-19 17:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-26 14:38 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-27 16:05 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-11 21:24 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-12 5:34 ` Eli Zaretskii
2022-06-12 20:56 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fsm9ut11.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=54802@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).