From: Eli Zaretskii <eliz@gnu.org>
To: Yilkal Argaw <yilkalargawworkneh@gmail.com>
Cc: 55800@debbugs.gnu.org
Subject: bug#55800: using rgrep function interactively with fido-mode or fido-vertical-mode causes errors
Date: Sun, 05 Jun 2022 16:02:46 +0300 [thread overview]
Message-ID: <83fskj9sax.fsf@gnu.org> (raw)
In-Reply-To: <CAJddU=ot4BHXmtW6jFGFniz8KcyPo=_2JLXNK9cQUAPiOFvSTg@mail.gmail.com> (message from Yilkal Argaw on Sun, 5 Jun 2022 15:36:37 +0300)
[Please use Reply All to keep the discussion recorded by the bug tracker.]
> From: Yilkal Argaw <yilkalargawworkneh@gmail.com>
> Date: Sun, 5 Jun 2022 15:36:37 +0300
>
> > from:Eli Zaretskii <eliz@gnu.org>
> > to:Yilkal Argaw <yilkalargawworkneh@gmail.com>
> > cc:55800@debbugs.gnu.org
> > date:Jun 5, 2022, 12:47 PM
> >
> > The problem seems to be in grep-read-files, when fido-mode is used:
> > the prompt says "default all", but fido understands RET as selecting
> > the currently-highlighted candidate, which happens to be "./" -- and
> > that, of course, makes no sense as an argument to "-name".
>
> Why does the completion even show file names? In counsel-rg which
> is a command that does similar thing from in the counsel package,the
> second step shows file extension types like c,cpp,el. Can the behaviour
> of the behaviour be modified to show such completion options.
The completion shows file names because the code calls
read-file-name-internal. Try the same without fido, and at the prompt
for the wildcard type '?' -- you will see a list of files. That's
what fido shows.
Why that code calls read-file-name-internal, I don't know; perhaps
because it wants to support the use case of searching a single file or
files in a directory?
next prev parent reply other threads:[~2022-06-05 13:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-05 1:11 bug#55800: using rgrep function interactively with fido-mode or fido-vertical-mode causes errors Yilkal Argaw
2022-06-05 5:45 ` Eli Zaretskii
2022-06-05 7:15 ` Yilkal Argaw
2022-06-05 7:20 ` Yilkal Argaw
2022-06-05 9:46 ` Eli Zaretskii
[not found] ` <CAJddU=ot4BHXmtW6jFGFniz8KcyPo=_2JLXNK9cQUAPiOFvSTg@mail.gmail.com>
2022-06-05 13:02 ` Eli Zaretskii [this message]
2022-06-05 13:25 ` Yilkal Argaw
2022-06-08 7:19 ` Juri Linkov
2022-06-09 11:11 ` Yilkal Argaw
2022-06-09 17:09 ` Juri Linkov
2022-06-10 3:34 ` Yilkal Argaw
2022-06-10 7:58 ` Juri Linkov
2022-06-12 18:24 ` Juri Linkov
2022-06-13 7:20 ` Juri Linkov
2022-06-13 15:13 ` Yilkal Argaw
2022-06-13 17:20 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fskj9sax.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=55800@debbugs.gnu.org \
--cc=yilkalargawworkneh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).