unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Bill Sacks <sacks@ucar.edu>
Cc: 56397@debbugs.gnu.org
Subject: bug#56397: 28.1; Incorrect behavior of buffer-modified-p after undo in indirect buffer
Date: Thu, 07 Jul 2022 11:59:02 +0300	[thread overview]
Message-ID: <83fsjd5meh.fsf@gnu.org> (raw)
In-Reply-To: <08ce3b7e-2f84-795e-9f11-a3b1d1fc83a0@ucar.edu> (message from Bill Sacks on Tue, 5 Jul 2022 07:24:29 -0600)

> From: Bill Sacks <sacks@ucar.edu>
> Date: Tue, 5 Jul 2022 07:24:29 -0600
> 
> When working in a cloned indirect buffer, if I type something then save the buffer then undo my changes,
> buffer-modified-p returns nil and I am not able to save the version with these changes undone.
> 
> Steps to reproduce:
> 
> 1. Create a text buffer with some text in it (e.g., test.txt) and save it
> 2. Clone the buffer with M-x clone-indirect-buffer
> 3. Type some more text into the indirect buffer (e.g., test.txt<2>) and save it with C-x C-s
> 4. While still in the indirect buffer, undo the text entered in (3) with C-/ until the buffer has returned to the state
> at the start of (3)
> 5. Notice that (buffer-modified-p) returns nil. Attempting to save the buffer gives the message "(No changes
> need to be saved)". However, viewing the file on disk shows that it is still at the state from the end of (3).

Thanks, I think I've now fixed this on the master branch.





  reply	other threads:[~2022-07-07  8:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-05 13:24 bug#56397: 28.1; Incorrect behavior of buffer-modified-p after undo in indirect buffer Bill Sacks
2022-07-07  8:59 ` Eli Zaretskii [this message]
     [not found]   ` <431108d4-b611-10fe-fddf-0b3749069858@ucar.edu>
2022-07-07 13:48     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fsjd5meh.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=56397@debbugs.gnu.org \
    --cc=sacks@ucar.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).