* bug#58973: tab navigation in EWW misses textarea and select
@ 2022-11-02 21:28 Nicolas Graner
2022-11-03 6:20 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Graner @ 2022-11-02 21:28 UTC (permalink / raw)
To: 58973
In EWW mode, the function shr-next-link moves to the next active area,
which may be a link or an 'input' tag. To make tab navigation in forms
really operational, it should also stop at 'textarea' and 'select' tags.
Below is my suggested patch.
Hope this helps,
Nicolas
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 414de931c4..3799ef96e8 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1596,7 +1596,8 @@ eww-tag-textarea
(list :eww-form eww-form
:value value
:type "textarea"
- :name (dom-attr dom 'name)))))
+ :name (dom-attr dom 'name)))
+ (put-text-property start (1+ start) 'shr-tab-stop t)))
(defun eww-tag-input (dom)
(let ((type (downcase (or (dom-attr dom 'type) "text")))
@@ -1660,7 +1661,8 @@ eww-tag-select
(add-face-text-property start (point) 'eww-form-select)
(put-text-property start (point) 'keymap eww-select-map)
(unless (= start (point))
- (put-text-property start (1+ start) 'help-echo "select field"))
+ (put-text-property start (1+ start) 'help-echo "select field")
+ (put-text-property start (1+ start) 'shr-tab-stop t))
(shr-ensure-paragraph))))
(defun eww-select-display (select)
^ permalink raw reply related [flat|nested] 4+ messages in thread* bug#58973: tab navigation in EWW misses textarea and select
2022-11-02 21:28 bug#58973: tab navigation in EWW misses textarea and select Nicolas Graner
@ 2022-11-03 6:20 ` Eli Zaretskii
2022-11-07 14:32 ` Nicolas Graner
0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2022-11-03 6:20 UTC (permalink / raw)
To: Nicolas Graner; +Cc: 58973
> From: Nicolas Graner <nicolas@graner.name>
> Date: Wed, 02 Nov 2022 22:28:45 +0100
>
> In EWW mode, the function shr-next-link moves to the next active area,
> which may be a link or an 'input' tag. To make tab navigation in forms
> really operational, it should also stop at 'textarea' and 'select' tags.
>
> Below is my suggested patch.
Thanks. Can you provide a URL which could be used to test this?
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#58973: tab navigation in EWW misses textarea and select
2022-11-03 6:20 ` Eli Zaretskii
@ 2022-11-07 14:32 ` Nicolas Graner
2022-11-10 9:47 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Graner @ 2022-11-07 14:32 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 58973
Sorry for forgetting about this.
Try <tab> and <backtab> in this page:
http://graner.name/test-form.html
Nicolas
Eli Zaretskii <eliz@gnu.org> a écrit le 03/11/2022 à 08h20 :
>> From: Nicolas Graner <nicolas@graner.name>
>> Date: Wed, 02 Nov 2022 22:28:45 +0100
>>
>> In EWW mode, the function shr-next-link moves to the next active area,
>> which may be a link or an 'input' tag. To make tab navigation in forms
>> really operational, it should also stop at 'textarea' and 'select' tags.
>>
>> Below is my suggested patch.
>
> Thanks. Can you provide a URL which could be used to test this?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-10 9:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-02 21:28 bug#58973: tab navigation in EWW misses textarea and select Nicolas Graner
2022-11-03 6:20 ` Eli Zaretskii
2022-11-07 14:32 ` Nicolas Graner
2022-11-10 9:47 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).