From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59137: [PATCH] To minor changes related to overlays Date: Wed, 30 Nov 2022 15:25:41 +0200 Message-ID: <83fse0lgkq.fsf@gnu.org> References: <87edudm43j.fsf@rfc20.org> <834jv7rt5p.fsf@gnu.org> <87edu46r4z.fsf@rfc20.org> <87k03hpkwh.fsf@rfc20.org> <87h6yhpd1b.fsf@rfc20.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4470"; mail-complaints-to="usenet@ciao.gmane.io" Cc: matt@rfc20.org, monnier@iro.umontreal.ca, 59137@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 30 14:27:50 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0N7u-00011I-F1 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Nov 2022 14:27:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0N7A-00038C-7K; Wed, 30 Nov 2022 08:27:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0N78-00036h-9A for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 08:27:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0N78-0006JM-09 for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 08:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p0N77-0005B7-SK for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 08:27:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Nov 2022 13:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59137 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59137-submit@debbugs.gnu.org id=B59137.166981478019892 (code B ref 59137); Wed, 30 Nov 2022 13:27:01 +0000 Original-Received: (at 59137) by debbugs.gnu.org; 30 Nov 2022 13:26:20 +0000 Original-Received: from localhost ([127.0.0.1]:32768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0N6S-0005Am-4P for submit@debbugs.gnu.org; Wed, 30 Nov 2022 08:26:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0N6Q-0005Af-NB for 59137@debbugs.gnu.org; Wed, 30 Nov 2022 08:26:19 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0N6L-0005z8-4u; Wed, 30 Nov 2022 08:26:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=V+rS167qLbaqySVtJWhrbxE+odd+ZYpgRZ46FYuPbY8=; b=m8CPH5m2AJ+W M+lmkJGkAz42hjQzLjm/a0rxe6hgcXqVTI72LiOLRYwUrXxFxsWUAWogiw2OzVzwy409xHwE4+GfT ggs733dM3TgJIJ+KsWfspOR0BSs6svNlunOZEBIuDfHPaOHseN03VKyN/ohoWA25uTEGFyTnM847L pub1tOtoQrEeeKO/8Wp+LjduJQqayqVQiMfOHZPGzEPIpG04QTTHKTI6YryzK308wDXwO1FtUkhnN ikn3wBj4/9O9Hl4C3AxeXzPeazX1In8YXFF3JJXhH06kwlQ4sGYnluuCPYtt/4Flgc5Y+Pz0YFlgL mtWJh0ZIchLmZXz/JnUBSg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0N6K-0007BP-J5; Wed, 30 Nov 2022 08:26:12 -0500 In-Reply-To: (message from Stefan Kangas on Wed, 30 Nov 2022 02:28:09 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249494 Archived-At: > From: Stefan Kangas > Date: Wed, 30 Nov 2022 02:28:09 +0100 > Cc: Stefan Monnier , Eli Zaretskii , 59137@debbugs.gnu.org > > Matt Armstrong writes: > > > The admittedly redundant NULL check done by itree_empty_p does not > > change semantics or cause harm. mark_overlays in alloc.c is a recursive > > function so it handles NULL itself, hence the NULL check was omitted in > > the original code. > > Thanks. > > I guess as this is a minor cleanup this should go to master at this point. I agree. We can always cherry-pick if we find a good reason.