From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60623: 30.0.50; Add forward-sentence with tree sitter support Date: Sun, 08 Jan 2023 21:57:51 +0200 Message-ID: <83fsckpznk.fsf@gnu.org> References: <87o7ratva2.fsf@thornhill.no> <87bkn9tasb.fsf@thornhill.no> <83sfgloz5w.fsf@gnu.org> <875ydgu8dd.fsf@thornhill.no> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13439"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60623@debbugs.gnu.org, juri@linkov.net, casouri@gmail.com, monnier@iro.umontreal.ca, mardani29@yahoo.es To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 08 20:58:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pEboE-0003Kj-0X for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Jan 2023 20:58:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pEbnz-0003vp-Fo; Sun, 08 Jan 2023 14:58:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEbnw-0003u1-7d for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2023 14:58:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pEbnu-0005g0-E5 for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2023 14:58:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pEbnu-00074r-9O for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2023 14:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Jan 2023 19:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60623 X-GNU-PR-Package: emacs Original-Received: via spool by 60623-submit@debbugs.gnu.org id=B60623.167320785927176 (code B ref 60623); Sun, 08 Jan 2023 19:58:02 +0000 Original-Received: (at 60623) by debbugs.gnu.org; 8 Jan 2023 19:57:39 +0000 Original-Received: from localhost ([127.0.0.1]:34763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEbnX-00074D-EV for submit@debbugs.gnu.org; Sun, 08 Jan 2023 14:57:39 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEbnT-00073z-4b for 60623@debbugs.gnu.org; Sun, 08 Jan 2023 14:57:38 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEbnM-0005bM-Jd; Sun, 08 Jan 2023 14:57:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LsTvO93BqT7jdpEKaCn+InwdjG5wSSOYla910B1o2aE=; b=HoXGej5s1Fti eI16y8KhXq2QdfJNmRgYbEpHsWYHZmQI1j0sT0OGoLTGgRshUdjwDzMlF1tHEUurU3twSC86KNju+ 3r2qXaJhpftSEhVsALgOPhy1MhQrsipKga1Vr44aMX9bahn/MRaON/er/comvATAE5ud9Q0Uhcj3v 9CKZJZ5sI9zi06v4lIBPWnwvvTrkFoFspenVSGXe+2wcrKUgVtXIJRUftuAmcZBE6lDdr6RSpipqk q5/rkweTLlTyTU42W/LwfzINtG5a17grnTKqn0BhaFczy4AJJYmScTphZyRG0EQhetGOa+X2xmLyC jTxXCrxQ6UN2rirBM4TOug==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEbnM-0002UY-1D; Sun, 08 Jan 2023 14:57:28 -0500 In-Reply-To: <875ydgu8dd.fsf@thornhill.no> (message from Theodor Thornhill on Sun, 08 Jan 2023 20:35:58 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252957 Archived-At: > From: Theodor Thornhill > Cc: mardani29@yahoo.es, bug-gnu-emacs@gnu.org, 60623@debbugs.gnu.org, > casouri@gmail.com, monnier@iro.umontreal.ca, juri@linkov.net > Date: Sun, 08 Jan 2023 20:35:58 +0100 > > Eli Zaretskii writes: > > >> From: Theodor Thornhill > >> Cc: 60623@debbugs.gnu.org, casouri@gmail.com, eliz@gnu.org, > >> monnier@iro.umontreal.ca,Juri Linkov > >> Date: Sun, 08 Jan 2023 14:29:08 +0100 > >> > >> @Eli, what doc changes do you see as needed here? > > > > More or less. They need some polishing, like a few words about what > > does "sentence" mean in the tree-sitter context. But we can make > > these changes after this is in the repository. > > > > Thanks. > > > Ok, so in other words, this patch is good to go? Yes, I think so. > I omitted the additions to java-ts-mode and c-ts-mode. I can make a > separate commit to add some values that makes sense for multiple modes > after? SGTM. > Will the changes to the manual lie in "26.2 Sentences"? in the Emacs > manual? No, because these are not really sentences in some human-readable language, these are program parts. As such they should be somewhere under "27 Programs", possibly in "Defuns". However, "Sentences" might mention that programming modes have their own interpretation of "sentence" and corresponding movement commands.