From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser Date: Tue, 07 Feb 2023 14:24:06 +0200 Message-ID: <83fsbhpst5.fsf@gnu.org> References: <83edr3q8ez.fsf@gnu.org> <87o7q7dl4o.fsf@masteringemacs.org> <83a61rq6ck.fsf@gnu.org> <87k00uexdt.fsf@masteringemacs.org> <835yceris5.fsf@gnu.org> <87fsbievbi.fsf@masteringemacs.org> <83y1paq0pd.fsf@gnu.org> <83ilgep2ww.fsf@gnu.org> <4C7AB77E-FBB6-4F34-A73A-297243E2E3AF@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3571"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61235@debbugs.gnu.org, mickey@masteringemacs.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 07 13:25:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pPN2B-0000g1-84 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Feb 2023 13:25:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPN21-0005FY-9G; Tue, 07 Feb 2023 07:25:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPN1y-0005F8-VN for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2023 07:25:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPN1y-0007d0-L5 for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2023 07:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPN1y-0003ml-3p for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2023 07:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Feb 2023 12:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61235 X-GNU-PR-Package: emacs Original-Received: via spool by 61235-submit@debbugs.gnu.org id=B61235.167577264214474 (code B ref 61235); Tue, 07 Feb 2023 12:25:02 +0000 Original-Received: (at 61235) by debbugs.gnu.org; 7 Feb 2023 12:24:02 +0000 Original-Received: from localhost ([127.0.0.1]:51412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPN0x-0003ky-4l for submit@debbugs.gnu.org; Tue, 07 Feb 2023 07:24:02 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPN0v-0003kk-AE for 61235@debbugs.gnu.org; Tue, 07 Feb 2023 07:23:57 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPN0p-0007WV-GR; Tue, 07 Feb 2023 07:23:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=1NQ102AQJhwil0x+p4CnAbDhab+UK74lAen9FfsyFh0=; b=Xdsd10Fs74LvZK8AM8jq HFGSXr2kOTKZZITcOvkTJ7ZVgv0Syj8mr9sxXPj4F2RughjaL0BMaUM4nCiEPmaI3eBShWRFuVdnD TQ33F0/OfBa1rMx7AZ1uWXlWYZHbVcSUX3LSDgv6WQpwTiRM1wmOwDj74C6TWv5v2ia4/2jYkGtxx 8ZglIZiu2o7GlqchhC9ybwe2TxSPrL/9OaaN/XU072E79bf9qb26Wvrapb4O175VN8KCLTyZ0QHrV PdS1v4khclFQH7WUdH+xm9UYDuq5PIAakfVUnVKMtLevNia74yU/T7Z3oPZFvmF2p26lMJ5aI9zIe 2gt0UyHxjmXz2w==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPN0o-0000OC-WB; Tue, 07 Feb 2023 07:23:51 -0500 In-Reply-To: <4C7AB77E-FBB6-4F34-A73A-297243E2E3AF@gmail.com> (message from Yuan Fu on Mon, 6 Feb 2023 20:55:38 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255035 Archived-At: > From: Yuan Fu > Date: Mon, 6 Feb 2023 20:55:38 -0800 > Cc: Mickey Petersen , > 61235@debbugs.gnu.org > > >>> Yuan, any reason not to extend treesit-node-check instead? > >> > >> I did extend treesit-node-check in the patch. But I also added a function treesit-parser-live-p, which makes the same check but directly on a parser. It just made sense to me that if we let treesit-node-check check the nodes’ parser’s status, we’d also add a function to allow directly checking the status of a parser. > > > > That additional function would signal an error in the case discussed > > here, so I'm not sure we should add it in that shape, or at all. Why > > isn't treesit-node-check enough? > > Oops, it shouldn’t have. The updated patch fixes that. Treesit-node-check is enough, it just made more sense implentattion-wise, to implement that function that checks a parser, and let treesit-node-check use that function to check the node’s parser. We can choose to not expose that function, and only expose this feature through treesit-node-check, if you prefer so. I think treesit-node-check alone should be enough. One comment: > @@ -1943,9 +1959,11 @@ DEFUN ("treesit-node-check", > result = ts_node_is_extra (treesit_node); > else if (EQ (property, Qhas_error)) > result = ts_node_has_error (treesit_node); > + else if (EQ (property, Qlive)) > + result = Ftreesit_parser_live_p (XTS_NODE (node)->parser); Ftreesit_parser_live_p returns a Lisp object, whereas 'result' is a C 'bool' type. This won't compile if you configure with "--enable-check-lisp-object-type".