From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61726: [PATCH] Eglot: Support positionEncoding capability Date: Fri, 24 Feb 2023 14:18:41 +0200 Message-ID: <83fsavntni.fsf@gnu.org> References: <87a614g628.fsf@gmail.com> <83cz60r7hu.fsf@gnu.org> <875ybsfvtj.fsf@gmail.com> <831qmgr17p.fsf@gnu.org> <87wn48ecdz.fsf@gmail.com> <83v8jspgnr.fsf@gnu.org> <87lekodxja.fsf@gmail.com> <83a614p4sh.fsf@gnu.org> <87cz60dus9.fsf@gmail.com> <835ybrpnqj.fsf@gnu.org> <87y1oncz09.fsf@gmail.com> <83r0ufo3uc.fsf@gnu.org> <87356vbf0b.fsf@gmail.com> <83pm9znw0i.fsf@gnu.org> <83ilfrnum2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23222"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61726@debbugs.gnu.org, arstoffel@gmail.com To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 24 13:19:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVX2b-0005tH-Ha for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Feb 2023 13:19:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVX2V-0002kI-Mp; Fri, 24 Feb 2023 07:19:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVX2U-0002k8-8z for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2023 07:19:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVX2T-0005hY-WF for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2023 07:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pVX2T-0001e1-Rn for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2023 07:19:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Feb 2023 12:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61726 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61726-submit@debbugs.gnu.org id=B61726.16772411286295 (code B ref 61726); Fri, 24 Feb 2023 12:19:01 +0000 Original-Received: (at 61726) by debbugs.gnu.org; 24 Feb 2023 12:18:48 +0000 Original-Received: from localhost ([127.0.0.1]:36217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVX2G-0001dT-IJ for submit@debbugs.gnu.org; Fri, 24 Feb 2023 07:18:48 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVX2F-0001dH-2F for 61726@debbugs.gnu.org; Fri, 24 Feb 2023 07:18:47 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVX29-0005df-Mb; Fri, 24 Feb 2023 07:18:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=GbCL/Afvyx/kedp590YjIbLlV2eqnrPzfDfgFf4vt58=; b=XgNQVA1r/VFDpFI/pkRg pYEJLkvfiZK+9mR1JHLGCJKHOTMEARz8Xbtvnlsn5WUzCVIitN3fVKInjWlZ4qIqKWafZEG5sC8p2 w5pQlDI0yNZll7keYcw6j7utAByefEh/5sR187PMD9xZrsDgUbgYILZiXPxwkAEqJjszg2R/3ZDAY AJrP2zUW4+0c7ehqdssvmg/YIC82IN2L1wdfjytC+P7xdLx5dri5guoB4hOYZ6JyiesT34qQdkWcn +t67oRO2ygH8Ky+JwXTvQD4XFerYn7cDnSLRoMI0KsAEVOGW67w1VSxaKGfBNIn+V1de0i34vh9aw PA7hhrspdoiA6w==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVX28-0003Hm-VG; Fri, 24 Feb 2023 07:18:41 -0500 In-Reply-To: (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Fri, 24 Feb 2023 12:09:14 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256581 Archived-At: > From: João Távora > Date: Fri, 24 Feb 2023 12:09:14 +0000 > Cc: arstoffel@gmail.com, 61726@debbugs.gnu.org > > On Fri, Feb 24, 2023 at 11:57 AM Eli Zaretskii wrote: > > > > eglot-current-column is a user-visible function. would need > > > obsoletion aliases. > > > > Yes. But that is not a problem, from my POV. > > True. > > > > Are you sure it isn't better just to add some clarifying comments? > > > > I'm okay with that as well, but the clarifications should be in doc > > strings of public functions as well, if we go that way. > > Yes, makes sense. I'll let you decide what is cleaner: sweeping > renames or docstrings. And thanks in advance. I'm not doing the job, so I think this is up to Augusto. > > > So maybe, just maybe, this can be removed. And the full test suite must > > > run afterwards. And then probably more tests should be added. > > > > How about removing it on master? > > Doesn't make much of a difference because ELPA :core package. > If the change is harmful, that harm will be visible "soon". > I think we can just add some tests to eglot-tests.el and > test the problematic case collected from the old bug tracker, > if it's not being tested already. Fine by me.