From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' Date: Fri, 03 Mar 2023 09:31:15 +0200 Message-ID: <83fsamcmv0.fsf@gnu.org> References: <877cw4tpap.fsf@ledu-giraud.fr> <838rgfe39g.fsf@gnu.org> <87ttz3jnzo.fsf@ledu-giraud.fr> <831qm7dzpg.fsf@gnu.org> <87lekfjh4q.fsf@ledu-giraud.fr> <87h6v3jgm8.fsf@ledu-giraud.fr> <871qm6po08.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10674"; mail-complaints-to="usenet@ciao.gmane.io" Cc: manuel@ledu-giraud.fr, 61816@debbugs.gnu.org To: Visuwesh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 03 08:32:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXzu0-0002Zx-1J for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Mar 2023 08:32:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXzti-0008Bd-42; Fri, 03 Mar 2023 02:32:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXztc-0008BI-CK for bug-gnu-emacs@gnu.org; Fri, 03 Mar 2023 02:32:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXzta-0008E6-Cx for bug-gnu-emacs@gnu.org; Fri, 03 Mar 2023 02:32:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pXzta-0002FB-7e for bug-gnu-emacs@gnu.org; Fri, 03 Mar 2023 02:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Mar 2023 07:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61816-submit@debbugs.gnu.org id=B61816.16778287058594 (code B ref 61816); Fri, 03 Mar 2023 07:32:02 +0000 Original-Received: (at 61816) by debbugs.gnu.org; 3 Mar 2023 07:31:45 +0000 Original-Received: from localhost ([127.0.0.1]:59509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXztJ-0002EY-JK for submit@debbugs.gnu.org; Fri, 03 Mar 2023 02:31:45 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXztH-0002EH-M8 for 61816@debbugs.gnu.org; Fri, 03 Mar 2023 02:31:44 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXztC-00089K-6U; Fri, 03 Mar 2023 02:31:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=lreGGUFGEOAVP3WUniu/TMRN3IVj5zcINNTegOsiyhA=; b=BGIS8dITZizR+lfJlpQ1 +hxi48eDfgxRmFLKLm3QmM+O2CtEiCGNve0teTW43C4O8+r290QP930h9u734Mihhe7wqWWmnvvJw IcpAo8B2mB0ACqQ9NEzbPbrepfb4rhvnsWbJ5aEnuA3VX5jGRDsSykkkKjzCmFx9aZi/FmJb/pi7X 0XcEP8FHT2NaaVh+F8TqR/Ooda45Q4WWose3tqmjoW1hwasF9utb8YdaWXh00Y1W9tcEwGsoij+ew 0jLXGyD3cgRhYZ6lETf6oydmQWqMD8kFRrHD45sltMyu4jBFJD+7GtKc3jCCritWg5DhWu+8evmSr a5l2joj3EHqmKQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXzt4-00023z-Ca; Fri, 03 Mar 2023 02:31:37 -0500 In-Reply-To: <871qm6po08.fsf@gmail.com> (message from Visuwesh on Fri, 03 Mar 2023 07:58:07 +0530) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257198 Archived-At: > From: Visuwesh > Cc: Eli Zaretskii , 61816@debbugs.gnu.org > Date: Fri, 03 Mar 2023 07:58:07 +0530 > > [வியாழன் மார்ச் 02, 2023] Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > > > Manuel Giraud writes: > > > >> Eli Zaretskii writes: > >> > >> [...] > >> > >>> You are right, of course. It just feels strange to need to cater to > >>> themes in a core package, when the way themes are supposed to > >>> customize Emacs exists and can be used in this case as well. > >>> > >>> Alternatively, maybe themes should have settings for features such as > >>> this one? > >> > >> Maybe, we could customize doc-view-svg-\(fore\|back\)ground in the > >> official Emacs themes for a start, WDYT? > > > > ... and in order to be able to use 'custom-theme-set-faces', we could > > have a 'doc-view-svg-face' (used only for its foreground and > > background). I'm caching you up slowly 😅 > > Themes can also use `custom-theme-set-variables' so I did not see a need > to introduce a face when I made the patch back then. The problem with custom-theme-set-variables is that themes have no clue which variables to customize: there are too many of them, and those that themes should customize don't stand out in any way, do they? Faces are better because themes always pay attention to them.