From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61637: 30.0.50; Fix Eglot tests that need HOME=~USER Date: Sat, 04 Mar 2023 20:09:24 +0200 Message-ID: <83fsak9ynf.fsf@gnu.org> References: <87ilfxv5dg.fsf@tcd.ie> <87h6vgelnn.fsf@tcd.ie> <83leksv6az.fsf@gnu.org> <87bkl972du.fsf@gmail.com> <87pm9oqvs1.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8654"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61637@debbugs.gnu.org, joaotavora@gmail.com To: Basil Contovounesios Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 04 19:10:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYWKs-00024X-Ob for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Mar 2023 19:10:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYWKb-0002Nl-2f; Sat, 04 Mar 2023 13:10:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYWKY-0002Nb-VY for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 13:10:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYWKY-0001El-IV for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 13:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pYWKY-00082D-6U for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 13:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Mar 2023 18:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61637 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61637-submit@debbugs.gnu.org id=B61637.167795338430851 (code B ref 61637); Sat, 04 Mar 2023 18:10:02 +0000 Original-Received: (at 61637) by debbugs.gnu.org; 4 Mar 2023 18:09:44 +0000 Original-Received: from localhost ([127.0.0.1]:37711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYWKG-00081W-B7 for submit@debbugs.gnu.org; Sat, 04 Mar 2023 13:09:44 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYWKE-00081K-GV for 61637@debbugs.gnu.org; Sat, 04 Mar 2023 13:09:42 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYWK8-0001BW-D1; Sat, 04 Mar 2023 13:09:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=S230vgiuiK9uPJyV+Lqc2JDcKDQEbJ7ElP2c8DJV3oA=; b=FX/gy88BYdfKCoQ7utgP d+0BP+CIpIJk+XB3g0gS82yfAdCIxjR6IMidu7AGsTDih4u6KZZGyAC/wInQYJZTTwKiccd4KEkjS vmHB9vJ8oqdHA4DnO6+i33K6+tcH1CdYuZ1rugj09QLOou5lCW/WHB2lEYq0Rwhzo/xOsyTJRGgNm KK9JiOnMznmBfVUtcIZxvIQTcGoLNYDa5RKWjsVxdzZzVY6o+3vkLTnLNZ5ui7VQqK482M7hY4Dyd RgY9jz8iIAUIwl1KbnsrZvibGRsYU0UAF501hzwNOEy5SCctQ8jWF4dyaLrGEPGykZ5gWdBWrk8ox g/gM7/f5iPBWTQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYWK7-0001Tm-Gm; Sat, 04 Mar 2023 13:09:36 -0500 In-Reply-To: <87pm9oqvs1.fsf@tcd.ie> (message from Basil Contovounesios on Sat, 04 Mar 2023 17:19:26 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257297 Archived-At: > From: Basil Contovounesios > Cc: Eli Zaretskii , 61637@debbugs.gnu.org > Date: Sat, 04 Mar 2023 17:19:26 +0000 > > João Távora [2023-03-04 01:04 +0000] wrote: > > > Another option is to have eglot-tests.el read a new environment var: > > > > diff --git a/test/lisp/progmodes/eglot-tests.el b/test/lisp/progmodes/eglot-tests.el > > index 5d5de59a19a..ad994915c52 100644 > > --- a/test/lisp/progmodes/eglot-tests.el > > +++ b/test/lisp/progmodes/eglot-tests.el > > @@ -116,9 +116,7 @@ eglot--call-with-fixture > > ;; installations for LSP servers like pylsp, making > > ;; these tests mostly useless, so we hack around it > > ;; here with a great big hack. > > - ,(format "HOME=%s" > > - (if (file-exists-p home) home > > - (format "/home/%s" (getenv "USER"))))) > > + ,(format "HOME=%s" (or (getenv "EGLOT_REAL_HOME") (getenv "HOME")))) > > process-environment)) > > ;; Prevent "Can't guess python-indent-offset ..." messages. > > (python-indent-guess-indent-offset-verbose . nil) > > > > This is acceptable for Eglot devs like me, but other devs that don't > > know about this variable will still be confused. WDYT? > > So the suggestion is for parties interested in running the full > unadulterated Eglot suite to set this environment variable, thus opting > into using their HOME or any other HOME-like environment they may have > set up? For process-environment only, i.e. for the LSP server that is being started. Presumably, not for Emacs itself.