unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Wilhelm Kirschbaum <wkirschbaum@gmail.com>
Cc: ruijie@netyu.xyz, luangruo@yahoo.com, 62155@debbugs.gnu.org
Subject: bug#62155: 30.0.50; elixir-ts-mode.elc warning
Date: Mon, 13 Mar 2023 16:33:18 +0200	[thread overview]
Message-ID: <83fsa8u3f5.fsf@gnu.org> (raw)
In-Reply-To: <878rg0n65g.fsf@gmail.com> (message from Wilhelm Kirschbaum on Mon, 13 Mar 2023 15:08:10 +0200)

> Cc: luangruo@yahoo.com, 62155@debbugs.gnu.org
> From: Wilhelm Kirschbaum <wkirschbaum@gmail.com>
> Date: Mon, 13 Mar 2023 15:08:10 +0200
> 
> I can see there is still an issue with loading heex-ts-mode from 
> elixir-ts-mode, but not quite sure how to
> immediately resolve it. I will have a look in a couple of hours.

One possibility is to add defvar for each variable defined by
heex-ts-mode that elixir-ts-mode needs to use, and remove the require
of heex-ts-mode.  Since heex-ts-mode is loaded at run time, I think
this should be enough.

> The problem is in the top of elixir-ts-mode.el: (require 
> 'heex-ts-mode) and then we call
> (treesit-ready-p 'heex) in heex-ts-mode.

Yes.

> I guess the intention with the convention here was to only load the
> -ts-mode when the user explicitly requires, but it breaks the way I
> called (require 'heex-ts-mode) from elixir-ts-mode.el.

Yes.





  reply	other threads:[~2023-03-13 14:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <877cvl9zgl.fsf.ref@yahoo.com>
2023-03-13  2:06 ` bug#62155: 30.0.50; elixir-ts-mode.elc warning Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-13 11:03   ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-13 13:08     ` Wilhelm Kirschbaum
2023-03-13 14:33       ` Eli Zaretskii [this message]
2023-03-13 20:07         ` Wilhelm Kirschbaum
2023-03-16  7:53           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fsa8u3f5.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=62155@debbugs.gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=ruijie@netyu.xyz \
    --cc=wkirschbaum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).