unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#63810: 29.0.91; typescript-ts-mode grammar missing the "is" keyword
@ 2023-05-31  7:30 Jimmy Yuen Ho Wong
  2023-05-31 12:21 ` Eli Zaretskii
  0 siblings, 1 reply; 5+ messages in thread
From: Jimmy Yuen Ho Wong @ 2023-05-31  7:30 UTC (permalink / raw)
  To: 63810


Reproduction:

1. C-x C-f test.ts
2. Insert
   ```typescript
   function isFish(pet: Fish | Bird): pet is Fish {
     return (pet as Fish).swim !== undefined;
   }
   ```
3. Observe the `is` keyword isn't highlighted.

Expectation:

TypeScript has a concept called type predicates, which introduces a
keyword called `is`.


[Reference](https://www.typescriptlang.org/docs/handbook/2/narrowing.html#using-type-predicates)





^ permalink raw reply	[flat|nested] 5+ messages in thread
* bug#63810: 29.0.91; typescript-ts-mode grammar missing the "is" keyword
  2023-05-31  7:30 bug#63810: 29.0.91; typescript-ts-mode grammar missing the "is" keyword Jimmy Yuen Ho Wong
@ 2023-05-31 12:21 ` Eli Zaretskii
  2023-05-31 13:20   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2023-05-31 12:21 UTC (permalink / raw)
  To: Jimmy Yuen Ho Wong, Theodor Thornhill, Jostein Kjonigsen, Yuan Fu; +Cc: 63810

> From: Jimmy Yuen Ho Wong <wyuenho@gmail.com>
> Date: Wed, 31 May 2023 08:30:14 +0100
> 
> 1. C-x C-f test.ts
> 2. Insert
>    ```typescript
>    function isFish(pet: Fish | Bird): pet is Fish {
>      return (pet as Fish).swim !== undefined;
>    }
>    ```
> 3. Observe the `is` keyword isn't highlighted.
> 
> Expectation:
> 
> TypeScript has a concept called type predicates, which introduces a
> keyword called `is`.

Thanks.

Can you guys please look into this?





^ permalink raw reply	[flat|nested] 5+ messages in thread
* bug#63810: 29.0.91; typescript-ts-mode grammar missing the "is" keyword
  2023-05-31 12:21 ` Eli Zaretskii
@ 2023-05-31 13:20   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2023-05-31 18:51     ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 5+ messages in thread
From: Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-05-31 13:20 UTC (permalink / raw)
  To: Eli Zaretskii, Jimmy Yuen Ho Wong, Jostein Kjonigsen, Yuan Fu; +Cc: 63810



On 31 May 2023 14:21:50 CEST, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Jimmy Yuen Ho Wong <wyuenho@gmail.com>
>> Date: Wed, 31 May 2023 08:30:14 +0100
>> 
>> 1. C-x C-f test.ts
>> 2. Insert
>>    ```typescript
>>    function isFish(pet: Fish | Bird): pet is Fish {
>>      return (pet as Fish).swim !== undefined;
>>    }
>>    ```
>> 3. Observe the `is` keyword isn't highlighted.
>> 
>> Expectation:
>> 
>> TypeScript has a concept called type predicates, which introduces a
>> keyword called `is`.
>
>Thanks.
>
>Can you guys please look into this?

Thanks for the ping. Will look into it this evening.

Theo





^ permalink raw reply	[flat|nested] 5+ messages in thread
* bug#63810: 29.0.91; typescript-ts-mode grammar missing the "is" keyword
  2023-05-31 13:20   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-05-31 18:51     ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2023-06-01 11:58       ` Eli Zaretskii
  0 siblings, 1 reply; 5+ messages in thread
From: Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-05-31 18:51 UTC (permalink / raw)
  To: Eli Zaretskii, Jimmy Yuen Ho Wong, Jostein Kjonigsen, Yuan Fu; +Cc: 63810

Theodor Thornhill <theo@thornhill.no> writes:

> On 31 May 2023 14:21:50 CEST, Eli Zaretskii <eliz@gnu.org> wrote:
>>> From: Jimmy Yuen Ho Wong <wyuenho@gmail.com>
>>> Date: Wed, 31 May 2023 08:30:14 +0100
>>> 
>>> 1. C-x C-f test.ts
>>> 2. Insert
>>>    ```typescript
>>>    function isFish(pet: Fish | Bird): pet is Fish {
>>>      return (pet as Fish).swim !== undefined;
>>>    }
>>>    ```
>>> 3. Observe the `is` keyword isn't highlighted.
>>> 
>>> Expectation:
>>> 
>>> TypeScript has a concept called type predicates, which introduces a
>>> keyword called `is`.
>>
>>Thanks.
>>
>>Can you guys please look into this?
>
> Thanks for the ping. Will look into it this evening.
>
> Theo


Now fixed on emacs-29.

Thanks again for the ping :)

Theo





^ permalink raw reply	[flat|nested] 5+ messages in thread
* bug#63810: 29.0.91; typescript-ts-mode grammar missing the "is" keyword
  2023-05-31 18:51     ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-06-01 11:58       ` Eli Zaretskii
  0 siblings, 0 replies; 5+ messages in thread
From: Eli Zaretskii @ 2023-06-01 11:58 UTC (permalink / raw)
  To: Theodor Thornhill; +Cc: 63810-done, casouri, jostein, wyuenho

> From: Theodor Thornhill <theo@thornhill.no>
> Cc: 63810@debbugs.gnu.org
> Date: Wed, 31 May 2023 20:51:59 +0200
> 
> Now fixed on emacs-29.

Thanks, closing.





^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-01 11:58 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-31  7:30 bug#63810: 29.0.91; typescript-ts-mode grammar missing the "is" keyword Jimmy Yuen Ho Wong
2023-05-31 12:21 ` Eli Zaretskii
2023-05-31 13:20   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-31 18:51     ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-01 11:58       ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).