From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64759: Broken faces Date: Fri, 21 Jul 2023 10:51:55 +0300 Message-ID: <83fs5h1z38.fsf@gnu.org> References: <86fs5h4vo2.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18011"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64759@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 21 09:52:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qMkw4-0004RW-W0 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Jul 2023 09:52:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qMkvq-0005QP-FF; Fri, 21 Jul 2023 03:52:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMkvl-0005Q2-Cf for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 03:52:06 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qMkvh-0006UF-Q1 for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 03:52:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qMkvh-00060R-Lu for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 03:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Jul 2023 07:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64759 X-GNU-PR-Package: emacs Original-Received: via spool by 64759-submit@debbugs.gnu.org id=B64759.168992588723044 (code B ref 64759); Fri, 21 Jul 2023 07:52:01 +0000 Original-Received: (at 64759) by debbugs.gnu.org; 21 Jul 2023 07:51:27 +0000 Original-Received: from localhost ([127.0.0.1]:60485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMkv9-0005zb-5j for submit@debbugs.gnu.org; Fri, 21 Jul 2023 03:51:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMkv6-0005zN-NA for 64759@debbugs.gnu.org; Fri, 21 Jul 2023 03:51:25 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMkv1-0006QZ-Er; Fri, 21 Jul 2023 03:51:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=iQb/IigLopeWOxSrLnpjBu4wdPfnQkgokJ0Ou/ONdS4=; b=BDH05EG0JiQF 5Nv54ZX14x71zD5g58Kj/vijbOiZ3zU8I8t/yUTM5v+Pkp4u8EV58HqTvz9LS9CA2/ICY2Qb7hTdc TVrrwY1KppOgqGy+XPIklAJxTJX/IaptEbDlnpY878tFWn5h6mZtltttOknmv27KeqNNgX9x4Aih8 PosZO+GtHWOMMxh9HZPMN5EI0JhUY5uZkv07QcHBR1Nj+7fAG98H21Ovi++IlqMf1EGVxheKj/g0O xPghUv7T8IX1B7sw4PTALe01oIZN2GdEQHio2JCPR+++B4BVvrzxUQa+Cp5SeO+VG0GLK60wxrNfN rZkNfypjwNlLoMYSVnehyg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMkv0-0006Fi-TI; Fri, 21 Jul 2023 03:51:19 -0400 In-Reply-To: <86fs5h4vo2.fsf@mail.linkov.net> (message from Juri Linkov on Fri, 21 Jul 2023 09:37:30 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265660 Archived-At: > From: Juri Linkov > Date: Fri, 21 Jul 2023 09:37:30 +0300 > > This change broke display of `display-time-date-and-time' on the tab-bar: > > diff --git a/lisp/time.el b/lisp/time.el > index 522bec46ac6..0184f96fcc2 100644 > --- a/lisp/time.el > +++ b/lisp/time.el > @@ -141,6 +141,7 @@ display-time-mail-face > (defface display-time-date-and-time nil > "Face for `display-time-format'." > + '((t (:inherit mode-line))) > :group 'mode-line-faces > :version "30.1") > > This face is used by `tab-bar-format-global' that has nothing to do > with the mode line, so inheriting from `mode-line' makes no sense. ??? It is AFAIU used whenever display-time-mode shows the time when display-time-day-and-date is non-nil. Where this is shown doesn't matter, and by default this is shown on the mode line. Thus "makes no sense" sounds somewhat harsh to me. But feel free to change the face definition as you see fit.