From: Eli Zaretskii <eliz@gnu.org>
To: monnier@iro.umontreal.ca
Cc: aqua0210@foxmail.com, 64989@debbugs.gnu.org
Subject: bug#64989: 29.1; Comment or uncomment lines in elisp-mode will show message in minibuffer
Date: Sat, 12 Aug 2023 09:43:54 +0300 [thread overview]
Message-ID: <83fs4og3px.fsf@gnu.org> (raw)
In-Reply-To: <83leeu292j.fsf@gnu.org> (message from Eli Zaretskii on Tue, 01 Aug 2023 16:20:20 +0300)
Ping! Stefan, any suggestions?
> Cc: 64989@debbugs.gnu.org
> Date: Tue, 01 Aug 2023 16:20:20 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> > From: Eason Huang <aqua0210@foxmail.com>
> > Date: Tue, 01 Aug 2023 19:13:59 +0800
> >
> > Hello Emacs,
> >
> > When update to the new released Emacs 29.1, I found that when comment or
> > uncomment lines in emacs-lisp-mode will show message in minibuffer as
> > below:
> > ```
> > combine-change-calls: buffer-undo-list broken
> > ```
> > Steps to reproduce:
> > 1. create a test.el file with any Elisp code. such as:
> > ```
> > (message "Test")
> > ```
> > 2. start emacs and open the test.el file with `emacs -Q ~/test.el`
> > 3. Use C-x C-; (comment-line) to comment the code in test.el
> > 4. Now you will see the message mentioned above.
>
> Thanks.
>
> Stefan, I think this is due to the commit below:
>
> | Author: Stefan Monnier <monnier@iro.umontreal.ca>
> | AuthorDate: Fri Jan 13 17:38:04 2023 -0500
> | Commit: Stefan Monnier <monnier@iro.umontreal.ca>
> | CommitDate: Fri Jan 13 17:38:04 2023 -0500
> |
> | * lisp/subr.el (combine-change-calls-1): Fix bug#60467
> |
> | Don't stop at timestamps. Strip them for now, to be on the safe side.
> | Don't merge into `master` where we'll use a better fix.
>
> My "partial bisecting" indicates that the bug was introduced between
> Dec 31, 2022 and Jan 31, 2023, and the above is the only commit
> in-between that could matter.
>
> If indeed this is the culprit, can we perhaps backport the "better
> fix" from master to the emacs-29 branch?
next prev parent reply other threads:[~2023-08-12 6:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 11:13 bug#64989: 29.1; Comment or uncomment lines in elisp-mode will show message in minibuffer Eason Huang
2023-08-01 13:20 ` Eli Zaretskii
2023-08-12 6:43 ` Eli Zaretskii [this message]
2023-08-16 16:12 ` Gregory Heytings
2023-08-24 6:19 ` Eli Zaretskii
2023-08-26 15:09 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-28 16:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-28 16:35 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fs4og3px.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=64989@debbugs.gnu.org \
--cc=aqua0210@foxmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).